1675537 - Switch browser.urlbar.update2.emptySearchBehavior to 0 for Firefox 83

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Marco Bonardo [:mak]]

On Verdi's request let's switch browser.urlbar.update2.emptySearchBehavior to 0 before releasing 83

Comment 1

[Marco Bonardo [:mak]]

[Tracking Requested - why for this release]: UX wants this change before we release the feature.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1675537 - Switch browser.urlbar.update2.emptySearchBehavior to 0. r=harry

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 9186027 [details]
Bug 1675537 - Switch browser.urlbar.update2.emptySearchBehavior to 0. r=harry

Beta/Release Uplift Approval Request

• User impact if declined: We are releasing Urlbar Update 2 in Firefox 83, but we decided to disable this sub-feature.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Entering Search Mode with an empty string (for example by clicking on a one-off search button without a search string, or CTRL+K) should not show search history or browsing history results.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just pref-flipping a sub feature of update2, that was one of the possible outcomes we planned.
• String changes made/needed:

Comment 4

[Marco Bonardo [:mak]]

Note: the patch is in queue for landing in Nightly, but autoland is closed atm. I filed the request sooner to anticipate this requirement to the stakeholders.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13659eaf695f
Switch browser.urlbar.update2.emptySearchBehavior to 0. r=harry

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/13659eaf695f

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9186027 [details]
Bug 1675537 - Switch browser.urlbar.update2.emptySearchBehavior to 0. r=harry

Approved for the beta branch before the merge, thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Landed for 83.0b10.
https://hg.mozilla.org/releases/mozilla-beta/rev/9b09b1ef281f

Comment 9

[Ralu]

Verified - Fixed in latest Beta 83.0b10 and Nightly 84.0a1 ( 20201109095222) using Windows 10 and Ubuntu 18.04 and Mac 10.15.

Comment 10

[lilydjwg]

I get here after a mozregression session. I don't quite understand what this change meant to users, and what do you think about my usage of this sub-feature?

I type a space to show my most frequently visited sites. I don't use the about:newtab's icons because it empathizes icons and shows part of domain below it, while I'm looking for website titles, and the urlbar completion is a very familiar thing.

Is this sub-feature going to fade away (like bug 712602 which removes the ability to show up frequently visited sites without using a keyboard), or it will stay in this form?

Comment 11

[Marco Bonardo [:mak]]

You're right, this should have only affected search engines in search mode, not other things. I'll file a bug.

Comment 12

[Marco Bonardo [:mak]]

(In reply to lilydjwg from comment #10)

I get here after a mozregression session.

This should now be fixed. Thank you for the report!