Closed Bug 1675558 Opened 4 years ago Closed 3 years ago

Make browser_searchMode_preview.js properly handle an empty search mode search

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
1

Tracking

()

RESOLVED FIXED
87 Branch
Iteration:
87.1 - Jan 25 - Feb 7
Tracking Status
firefox87 --- fixed

People

(Reporter: mak, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Changing browser.urlbar.update2.emptySearchBehavior to 0 causes this test to fail, it should not fail unless it's specifically testing the emptySearchBehavior.
For now in 1675537 I'm just setting the pref to 2 in the test, but if 0 ends up being the final value, the test should not rely on 2.

Iteration: --- → 86.3 - Jan 11 - Jan 24
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: 86.3 - Jan 11 - Jan 24 → 87.1 - Jan 25 - Feb 7

Looks like things have changed enough for that test to still work with that pref setter removed. I'll re-trigger the relevant jobs in this try run a few times to make sure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6aaae3827fd097159a7a83114a8e83594603aa88

Points: 2 → 1
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c62ebe2c479e
Remove emptySearchBehavior setter from browser_searchMode_preview.js. r=adw
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: