Closed Bug 1675607 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26423 - [dialog] Remove snapshotting position behaviour, replace with UA styles.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26423 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26423
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[dialog] Remove snapshotting position behaviour, replace with UA styles.

As above. This change implements the behaviour described by:
https://github.com/whatwg/html/pull/5936/files

This introduces an internal pseudo class ":-internal-modal" which
applies the additional style rules when the dialog goes modal.

Change-Id: I6d807fffd64b4f9c8ea57a2993ac755b23df8287

Reviewed-on: https://chromium-review.googlesource.com/2258897
WPT-Export-Revision: 04cb101d2e2701d8cc7568bae6b3ab293bfef756

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 12 subtests

Status Summary

Firefox

OK : 3
PASS: 18
FAIL: 10

Chrome

OK : 3
PASS: 23
FAIL: 5

Safari

OK : 3
FAIL: 28

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/rendering/non-replaced-elements/flow-content-0/dialog.html
Closed dialog in width: 540px iframe: FAIL (Chrome: PASS, Safari: FAIL)
Modal dialog in width: 540px iframe: FAIL (Chrome: FAIL, Safari: FAIL)
Closed dialog in width: 538px iframe: FAIL (Chrome: PASS, Safari: FAIL)
Modal dialog in width: 538px iframe: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/interactive-elements/the-dialog-element/abspos-dialog-layout.html
Dialog should still be centered when removed, and re-added to the document.: FAIL (Chrome: FAIL, Safari: FAIL)
Dialog should be recentered if showModal() is called after removing 'open'.: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/interactive-elements/the-dialog-element/centering.html
vertical-rl: tall viewport: FAIL (Chrome: PASS, Safari: FAIL)
vertical-lr: tall viewport: FAIL (Chrome: PASS, Safari: FAIL)
horizontal-tb (container vertical-rl): tall viewport: FAIL (Chrome: PASS, Safari: FAIL)
vertical-rl (container horizontal-tb) (dialog vertical-rl): tall viewport: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24461bd0698a [wpt PR 26423] - [dialog] Remove snapshotting position behaviour, replace with UA styles., a=testonly https://hg.mozilla.org/integration/autoland/rev/d41967e68e09 [wpt PR 26423] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.