Closed Bug 1675611 Opened 5 months ago Closed 5 months ago

Show tab-to-search onboarding results until they are interacted with three times

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
2

Tracking

()

RESOLVED FIXED
84 Branch
Iteration:
84.2 - Nov 2 - Nov 15
Tracking Status
firefox83 --- wontfix
firefox84 + fixed

People

(Reporter: harry, Assigned: harry)

References

Details

Attachments

(2 files)

[Tracking Requested - why for this release]:
This is an issue with search mode onboarding. Product and UX asked that it be fixed ASAP, which would be 84 at this point.


One bug with tab-to-search onboarding results is that each keystroke counts against the maximum number of times we show them. Since we show them at most twice per session, if the user types ama on the way to autofilling amazon.com, we show a onboarding result as they type a and m then show the normal-sized tab-to-seach result when they type the second a, since we "showed" the onboarding result twice in that session already.

Instead, once we show a tab-to-search onboarding result, we should continue to show it as long as the user continues to type characters in the autofilled domain. The whole engagement should only count once against the total number of times we show onboarding results.

Depends on: 1675622

This bug should restore the pref values incremented in bug 1675622 to normal values.

I think the strategy here was just too complex and wrong from the beginning, I should have put down my concerns more clearly at the beginning.

I suggest we move to something much simpler, just require the user to interact with it, for N sessions. For example, the user must interact with this result for at least 3 sessions (or 3 days, since one may have multi days sessions).

Engineering, Product, and UX discussed this bug in a meeting today. We decided to go with a modified version of Marco's proposal, where the user must interact with the onboarding result three times total to dismiss it. Interacting with the result simply means selecting it, whether that is tabbing/arrowing past it or clicking on it.

Since we are overcounting the number of times these onboarding results are seen in 83, we're going to reset any shown counters for 84 to ensure users see this onboarding message.

Summary: Continue to show tab-to-search onboarding results as long as the search engine domain is being autofilled → Show tab-to-search onboarding results until they are interacted with three times
Attachment #9187485 - Attachment description: Bug 1675611 - Show tab-to-search onboarding results until they are interacted with three times. r?mak! → Bug 1675611 - Part 2 - Show tab-to-search onboarding results until they are interacted with three times. r?mak!
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3505eb4f3af0
Part 1 - Add UrlbarProvider.onSelection. r=mak
https://hg.mozilla.org/integration/autoland/rev/519424ad964e
Part 2 - Show tab-to-search onboarding results until they are interacted with three times. r=mak
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.