Closed Bug 1675612 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26424 - Don't crash on SVG-as-canvas drawImage

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26424 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26424
Details from upstream follow.

b'Stephen Chenney <schenney@chromium.org>' wrote:

Don't crash on SVG-as-canvas drawImage

The check for same-origin for image files with EXIF in canvas
drawImage was crashing for SVG images because their security
origin status is not available until the image has loaded.

Change things to not check SVG images for canvas drawImage,
which is safe because the image will be checked when drawing
the SVG itself.

Add a test for various uses of images in SVG.

Bug: 1141412
Change-Id: I4bd39b6d10afec4c4134b24609aa02c53359361b
Reviewed-on: https://chromium-review.googlesource.com/2521049
WPT-Export-Revision: a2fff74b18a95cf3626bfd642c3d26741a498dfd

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL : 1

Chrome

FAIL : 1

Safari

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-images/image-orientation/image-orientation-none-cross-origin-svg.html: FAIL (Chrome: FAIL, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/412ae306531c
[wpt PR 26424] - Don't crash on SVG-as-canvas drawImage, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8ace7efbb97b
[wpt PR 26424] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/412ae306531c
https://hg.mozilla.org/mozilla-central/rev/8ace7efbb97b

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.