1675639 - Try to save some memory in the custom properties code.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Pages that use custom properties a lot may have a lot of these maps, but they're usually immutable, so we can try saving some memory here pretty easily.

This may help with bug 1656851.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1675639 - Don't waste string space before making values immutable. r=#style

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1675639 - Update indexmap. r=boris

New versions have shrink_to_fit().

Depends on D96130

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1675639 - Shrink custom property maps before making them immutable. r=#style

Depends on D96131

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d38566d80c6
Don't waste string space before making values immutable. r=boris
https://hg.mozilla.org/integration/autoland/rev/270207ea42c1
Update indexmap. r=boris
https://hg.mozilla.org/integration/autoland/rev/9a7b394ca845
Shrink custom property maps before making them immutable. r=boris

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for Bpgo bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/81a3ef82469bf0bfd2e85086f3dfa3f91724f323
Log link: https://treeherder.mozilla.org/logviewer?job_id=320908175&repo=autoland&lineNumber=15522

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ca763fe7152
Don't waste string space before making values immutable. r=boris
https://hg.mozilla.org/integration/autoland/rev/747cee56ec57
Update indexmap. r=boris
https://hg.mozilla.org/integration/autoland/rev/a933cf128e64
Shrink custom property maps before making them immutable. r=boris

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7ca763fe7152
https://hg.mozilla.org/mozilla-central/rev/747cee56ec57
https://hg.mozilla.org/mozilla-central/rev/a933cf128e64