167571 - fix CAB ui to have an AB picker for which AB to collect into, remove UI and code for "limit CAB size"

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

fix CAB ui to have an AB picker for which AB to collect into, remove UI and code
for "limit CAB size".

the picker can only show ABs that are writable (so no LDAP).

I think we should remove the code that does that altogether (from prefs UI,
default pref, and current CAB C++ code)

All this comes from mscott's document about how to fix the CAB.  See
http://rocknroll/users/mscott/publish/Documents/cab.html

Comment 1

[jglick]

Size Limit pref bug 158436.

Comment 2

[jglick]

http://www.mozilla.org/mailnews/specs/addressbook/#Prefs

Comment 3

[Scott MacGregor]

Here's the document on mozilla.org that talks about the CAB changes we'd like to
make:

http://www.mozilla.org/mailnews/arch/cab.html

Comment 4

[(not reading, please use [e-mail] instead)]

*** Bug 158436 has been marked as a duplicate of this bug. ***

Comment 5

[(not reading, please use [e-mail] instead)]

patch coming.  I got the UI fixed, now just fixing the back end...

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: UI works, BE doesn't compile yet. I'll finish tomorrow...

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: testing now...

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: add "New IM" button to ab toolbar. im's single user, chat invites multiple

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: patch, use Messenger::OpenURL() to launch the goim urls

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 12

[David :Bienvenu]

looks fine.

nit: in the two places this occurrs:
+  if (NS_FAILED(rv) || prefVal.IsEmpty())
+    rv = adCol->SetAbURI(kPersonalAddressbook);
+  else 
+    rv = adCol->SetAbURI(prefVal.get());
+

you could just use the ? operator here (up to you)
rv = adCol->SetAbUri((NS_FAILED(rv) || prefVal.IsEmpty()) ? kPersonalAddressBook
: prevVal.get())

Comment 13

[David :Bienvenu]

Comment on attachment 98748 [details] [diff] [review]
patch

sr=bienvenu

Comment 14

[(not reading, please use [e-mail] instead)]

I'll follow your suggestion before checking in, thanks.

Comment 15

[(not reading, please use [e-mail] instead)]

fixed.

see bug 168115, which covers the "IM" button.