Closed Bug 1675887 Opened 2 years ago Closed 2 years ago

Set Android vsync time to the timestamp from the frame callback

Categories

(Core :: Graphics, defect)

All
Android
defect

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

The AndroidVsyncSource currently ignores the timestamp from the callback and uses TimeStamp::Now(). This reduces the stability of the vsync timestamp deltas.

This makes the vsync times more consistent.
On a Pixel 2 running Android 11, the callback was called between 1ms and 6ms
after the vsync timestamp in my tests. Having the vsync timestamp slightly in
the past is what the rest of our vsync infrastructure expects.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/92a9dddf064d
Respect the time value that's passed to Choreographer.FrameCallback.doFrame. r=kats
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.