1676041 - Selecting multiple messages causes Delete button to be masked with dark blue

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Greg Hill]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

I selected more than one message for deletion after updating to the most recent TB 78.4.1 (32-bit).

Actual results:

The messages were selected, but the Delete button immediately below the message list was obscured by the background of the area containing the Delete button to change to the same color as the selected messages. On my system, that is dark blue. I can barely see the Delete button. Clicking the Delete button does the right thing.

Expected results:

Either the background of that area should not be turned dark blue, or the Delete lettering should be changed from black to a lighter color that can be seen over the dark blue background.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1676041-multimessage-buttons.patch

John, you can test this on Windows 10 High Contrast themes.

With HC-themes there is no difference between hovered and active buttons. Unfortunately we can't differ between Classic and HC-themes and Classic will also not have the hover active difference.

Comment 2

[John Bieling (:TbSync)]

Attachment: before-patch.PNG

Comment 3

[John Bieling (:TbSync)]

Attachment: after-patch.PNG

Comment 4

[John Bieling (:TbSync)]

Code of course looks fine. Is the change in the posted screenshots the expected outcome?

Comment 5

[Richard Marti (:Paenglab)]

(In reply to John Bieling (:TbSync) from comment #4)

Code of course looks fine. Is the change in the posted screenshots the expected outcome?

Yes, it's to make the buttons stand out of the background. Black is here the normal unhovered button background.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ecb3513ae547
Fix multimessage toolbarbuttons on Classic and High Contrast themes. r=TbSync DONTBUILD

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9186526 [details] [diff] [review]
1676041-multimessage-buttons.patch

[Approval Request Comment]
User impact if declined: Not clearly visible buttons on multimessage header.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1676041-multimessage-buttons-ESR.patch

[Approval Request Comment]
User impact if declined: Not clearly visible buttons on multimessage header.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9186629 [details] [diff] [review]
1676041-multimessage-buttons-ESR.patch

[Triage Comment]
Approved for esr78

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9186526 [details] [diff] [review]
1676041-multimessage-buttons.patch

[Triage Comment]
We aren't building another build for 83 beta, so this will appear in 84 beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/115648781441

Comment 12

[WaltS48 [:walts48]]

Looks okay to me in my test of the 78.5.0 release candidate on Windows 10 (20H2).