1676128 - UpdateExtraAddressProcessing function randomly throws exception "JavaScript component does not have a method named: "hasEmailAddress""

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Chris GAUDRY [:cmgaudry33]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.183 Safari/537.36

Steps to reproduce:

• Select a message in a folder
• Add multiple mailing lists from the Address books window
• Display the console

Actual results:

Some time the following exception is thrown :

[Exception... "JavaScript component does not have a method named: "hasEmailAddress"'JavaScript component does not have a method named: "hasEmailAddress"' when calling method: [nsIAbCard::hasEmailAddress]" nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: chrome://messenger/content/msgHdrView.js :: UpdateExtraAddressProcessing :: line 1546" data: no] msgHdrView.js:1546:17
UpdateExtraAddressProcessing chrome://messenger/content/msgHdrView.js:1543
updateExtraAddressProcessing chrome://messenger/content/mailWidgets.js:1225
OnAddressBookDataChanged chrome://messenger/content/msgHdrView.js:407
forEach self-hosted:225
OnAddressBookDataChanged chrome://messenger/content/msgHdrView.js:401
onItemAdded chrome://messenger/content/msgHdrView.js:380
notifyDirectoryItemAdded resource:///modules/AddrBookManager.jsm:521
addMailList resource:///modules/AddrBookDirectory.jsm:1105
...

Expected results:

No exception because :

• AddrBookMailling.asCard method should return a card implementing the hasEmailAddress method defined in the nsIAbCard interface.
• UpdateExtraAddressProcessing method should check if item is a mailing list or not before calling the hasEmailAddress, to be efficient.

Comment 1

[Chris GAUDRY [:cmgaudry33]]

Attachment: bug_1676128_AddrBookMailingList.diff

This patch add hasEmailAddress method implementation for mailinglist as card object.

Comment 2

[Chris GAUDRY [:cmgaudry33]]

Attachment: bug_1676128_msgHdrView.diff

This patch adds check on the item type before calling its method hasEmailAddress because no need to call this method if the item is a mailing list.

Comment 3

[Chris GAUDRY [:cmgaudry33]]

Attachment: bug_1676128_AddrBookMailingList.diff

Comment 4

[Chris GAUDRY [:cmgaudry33]]

Attachment: bug_1676128_msgHdrView.diff

Comment 5

[Chris GAUDRY [:cmgaudry33]]

Attachment: bug_1676128_AddrBookMailingList.diff

Comment 6

[Chris GAUDRY [:cmgaudry33]]

Attachment: bug_1676128_msgHdrView.diff

Comment 7

[Magnus Melin [:mkmelin]]

Chris, please remember to flag patches for review.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9186633 [details] [diff] [review]
bug_1676128_msgHdrView.diff

Review of attachment 9186633 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. r=mkmelin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a6a68fcf215a
Make UpdateExtraAddressProcessing function not throw Error of "does not have a method named: "hasEmailAddress" when mail lists are updated r=mkmelin

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9186633 [details] [diff] [review]
bug_1676128_msgHdrView.diff

[Approval Request Comment]
Cleaning up errors, quite safe to uplift

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9186633 [details] [diff] [review]
bug_1676128_msgHdrView.diff

[Triage Comment]
Approved for beta

Comment 12

[Dave Miller [:justdave]]

Thunderbird 84.0b2
https://hg.mozilla.org/releases/comm-beta/rev/f2cb00c1c2b5

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9186633 [details] [diff] [review]
bug_1676128_msgHdrView.diff

[Triage Comment]
Approved for esr78

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 78.5.1:
https://hg.mozilla.org/releases/comm-esr78/rev/d7af3f7cbc49