Closed Bug 1676185 Opened 11 months ago Closed 11 months ago

Pinning topsite moves the tile with + x position when sponsored topsites are active

Categories

(Firefox :: Top Sites, defect, P1)

Desktop
All
defect
Points:
2

Tracking

()

RESOLVED FIXED
84 Branch
Iteration:
84.2 - Nov 2 - Nov 15
Tracking Status
firefox82 --- unaffected
firefox83 --- wontfix
firefox84 --- fixed

People

(Reporter: pablo.muir, Assigned: dao, NeedInfo)

References

(Blocks 3 open bugs)

Details

Attachments

(2 files)

Attached image BUG2.jpg
[Suggested Severity:]

S3

[Description:]

Pinning a non-sponsored topsite will move the topsites from the current position.

[Environment:]

Windows 10
83.0b10-trybuild

[Preconditions:]

There are sponsored tiles listed in the topsites.

[Steps:]
  1. Download and install RO localized Firefox.
  2. Create an user.js and set: browser.topsites.useRemoteSetting = true and browser.search.region to "RO", connecting to the staging main-preview.
  3. Start the browser with the predefined profile.
  4. Open a new about:preferences#home and set topsites to be shown on 4 rows.
  5. Open a new tab.
  6. Pick any sponsored or non-sponsored topsite and choose to pin it using the menu.
[Actual Result:]

The topsite is pinned. The topsite is moved from the current position to position +x, where x represents the number of sponsored topsites in front of it.

[Expected Result:]

The topsite is pinned in the current position.

[Note:]

The behavior doesn’t reproduce if the sponsored top-sites are disabled. (browser.newtabpage.activity-stream.showSponsoredTopSites = false)

SEE SCREENSHOT ATTACHED, WARNER MOVED POSITION WHEN PINNED it also loosed its image.

Summary: Topsite loses pin after reorganized and jumps position → Pinning topsite moves the tile with + x position when sponsored topsites are active
See Also: → 1673429
Assignee: nobody → dao+bmo
Severity: -- → S3
Status: NEW → ASSIGNED
Iteration: --- → 84.2 - Nov 2 - Nov 15
Points: --- → 2
Flags: qe-verify+
Priority: -- → P1
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfe322864a91
Make pinning from the site menu work the same as pinning by drag & drop. r=mikedeboer
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Blocks: 1676174

Gave this a spin on 84.0a1 2020-11-12 / Windows 10 & Ubuntu 18.04 and at first glance it seems fixed, but I feel like a more deeper verification is required here. Leaving a reminder to reiterate on this one next round of testing.

Flags: needinfo?(adrian.florinescu)
You need to log in before you can comment on or make changes to this bug.