Closed
Bug 1676212
Opened 4 years ago
Closed 4 years ago
Only disable incremental barriers when necessary inside the GC
Categories
(Core :: JavaScript: GC, enhancement, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
At the moment we disable incremental barriers on entry to the GC and re-enable them again on exit. We added assertions that we don't do anything that checks the incremental barriers while we're marking, so we don't always need to do this.
Instead we can disable the barriers only where required. Currently this is only necessary during sweeping.
|
Assignee | |
Updated•4 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
|
Assignee | |
Comment 1•4 years ago
|
||
Now we have assertions that we don't trigger barriers when marking, we don't
need to disable them. We still need to disable them for sweeping as this does
trigger barriers.
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/649c45dbaf17 Don't disable incremental barrier during marking since we don't trigger these any more r=sfink
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•