Can enter CJK Characters when MOZ_UNICODE is set

RESOLVED FIXED in mozilla1.2beta

Status

()

Core
Internationalization
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Roy Yokoyama, Assigned: Roy Yokoyama)

Tracking

({intl})

Trunk
mozilla1.2beta
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
When MOZ_UNICODE is set, mozilla morph into an Unicode application.
However, WM_IME_CHAR message handler need to be updated accordingly.
Windows now sends IME char in UCS2 codepoint.  (before Unicode,
we were receiving locale codepoint)

Patch to follow.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2beta
(Assignee)

Comment 1

16 years ago
Created attachment 98525 [details] [diff] [review]
No need to call MultiByteToWideChar() in OnIMEChar() handler
(Assignee)

Comment 2

16 years ago
shanjian: can you review?

Updated

16 years ago
Keywords: intl

Comment 3

16 years ago
Comment on attachment 98525 [details] [diff] [review]
No need to call MultiByteToWideChar() in OnIMEChar() handler

Looks reasonable to me. r=shanjian
Attachment #98525 - Flags: review+
(Assignee)

Comment 4

16 years ago
kin: super review?

Comment 5

16 years ago
Comment on attachment 98525 [details] [diff] [review]
No need to call MultiByteToWideChar() in OnIMEChar() handler

sr=kin@netscape.com

Do we want to indent the old code that's in the new |else| clause?

Updated

16 years ago
Attachment #98525 - Flags: superreview+
(Assignee)

Comment 6

16 years ago
patch checked in with indentation.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

16 years ago
you only can verify this with Unicode build. We are in the process of
getting the MOZ_UNICODE flag on by _default_.  Please wait
until then.

Updated

16 years ago
QA Contact: ruixu → ylong
You need to log in before you can comment on or make changes to this bug.