Closed
Bug 167631
Opened 22 years ago
Closed 22 years ago
Can enter CJK Characters when MOZ_UNICODE is set
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.2beta
People
(Reporter: tetsuroy, Assigned: tetsuroy)
Details
(Keywords: intl)
Attachments
(1 file)
|
825 bytes,
patch
|
shanjian
:
review+
kinmoz
:
superreview+
|
Details | Diff | Splinter Review |
When MOZ_UNICODE is set, mozilla morph into an Unicode application. However, WM_IME_CHAR message handler need to be updated accordingly. Windows now sends IME char in UCS2 codepoint. (before Unicode, we were receiving locale codepoint) Patch to follow.
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2beta
|
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 2•22 years ago
|
||
shanjian: can you review?
|
||
Comment 3•22 years ago
|
||
Comment on attachment 98525 [details] [diff] [review] No need to call MultiByteToWideChar() in OnIMEChar() handler Looks reasonable to me. r=shanjian
Attachment #98525 -
Flags: review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
kin: super review?
Comment on attachment 98525 [details] [diff] [review] No need to call MultiByteToWideChar() in OnIMEChar() handler sr=kin@netscape.com Do we want to indent the old code that's in the new |else| clause?
Attachment #98525 -
Flags: superreview+
|
|
Assignee | |
Comment 6•22 years ago
|
||
patch checked in with indentation.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•22 years ago
|
||
you only can verify this with Unicode build. We are in the process of getting the MOZ_UNICODE flag on by _default_. Please wait until then.
You need to log in
before you can comment on or make changes to this bug.
Description
•