1676387 - [wpt-sync] Sync PR 26455 - Fix |LayoutNGBlockFlowMixin::InlineBlockBaseline|

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 26455 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26455
Details from upstream follow.

b'Koji Ishii <[e-mail]>' wrote:

Fix |LayoutNGBlockFlowMixin::InlineBlockBaseline|

r824961 crrev.com/c/2515933 copied the code from |LayoutBlock|
but the code in |LayoutBlockFlow| that prevents it from
running when |ChildrenInline| was not copied. This patch adds
the check.

Note, the test creates |LayoutNGCustom| in legacy, and adds a
|LayoutTextFragment| as a child of the |LayoutNGCustom|. Not
to blockify the child is likely an issue in |LayoutNGCustom|,
but this case could probably be reproduced by inline custom
layout or other inline objects that forces NG.

Bug: 1146789
Change-Id: I7ffacc2465ad205d13702dfda03433cc50c423f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526702
Commit-Queue: Koji Ishii \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Reviewed-by: Yoshifumi Inoue \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#825714}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e483355bad99bffddf7725488bb63695141eaec2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0720f62f9a45
[wpt PR 26455] - Fix |LayoutNGBlockFlowMixin::InlineBlockBaseline|, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0720f62f9a45