Remove devtools-splitter folder
Categories
(DevTools :: Debugger, task, P3)
Tracking
(firefox94 fixed)
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: jdescottes)
References
(Blocks 2 open bugs)
Details
Attachments
(6 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
The devtools-splitter was initially a copy of the shared splitter component we have in mozilla-central.
We should migrate all usage of devtools-splitter to the shared splitter, and remove the devtools-splitter folder.
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
Discussed with Nicolas, stealing this
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D125939
The custom drag:start and drag:end events are the main implementation difference I found between debugger's splitbox and the shared splitbox.
However I didn't find any usage for the classname it was setting, so I propose to remove it.
I tried to extensively use the splitters and didn't spot any issue.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D125940
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D125941
After removing devtools-splitter, the only css files picked up by the debugger build step are from react-aria-components, but they don't have individual license headers.
I am adding the regular mozilla license, I didn't find an easy way to create a license header matching the file being packaged by babel. And we were already not importing the right license text, so this is not a regression (for ref, the license is MIT)
|
|
Assignee | |
Comment 6•3 years ago
|
||
Depends on D125942
Not strictly related, but I was looking for build instructions and opened this file. The information is irrelevant and confusing nowadays, let's remove it.
|
|
Assignee | |
Comment 7•3 years ago
|
||
Depends on D125943
The Banner including the license text was introducing a white space which fails some of our linters.
The existing js files which were using the banner plugins are probably skipped from the whitespace checks, but vendors.css is not.
In any case the whitespace is useless so we should remove it.
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/530b30f4bbac [devtools] Remove devtools-splitter debugger package r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/772a6f3c5bb9 [devtools] Remove unused toggleDragging API from toolbox.js r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/a1498fc21bda [devtools] Regenerate debugger vendors after removing devtools-splitter r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/d8ce1a44ed20 [devtools] Add top license banner to debugger vendors.css r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/3d4d5284d46e [devtools] Remove irrelevant README related to debugger GitHub releases r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/ef6420c7989e [devtools] Remove whitespace added by the webpack Banner plugin r=nchevobbe
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/530b30f4bbac
https://hg.mozilla.org/mozilla-central/rev/772a6f3c5bb9
https://hg.mozilla.org/mozilla-central/rev/a1498fc21bda
https://hg.mozilla.org/mozilla-central/rev/d8ce1a44ed20
https://hg.mozilla.org/mozilla-central/rev/3d4d5284d46e
https://hg.mozilla.org/mozilla-central/rev/ef6420c7989e
Description
•