Closed Bug 1676439 Opened 4 years ago Closed 4 years ago

New Import button shouldn't show on the toolbar if DisableProfileImport policy is set

Categories

(Firefox :: Bookmarks & History, defect, P1)

defect

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

The new import button should not appear if the DisableProfileImport policy is set.

This can be checked with:

if (!Services.policies.isAllowed("profileImport")) {

Jared:

Do you think I should do this in maybeAddImportButton or in BrowserGlue.jsm to prevent the call to maybeAddImportButton?

Flags: needinfo?(jaws)

I would put this inside of maybeAddImportButton to limit the amount of code in the calling function in BrowserGlue.jsm. Also, maybeAddImportButton is already named for this occasion :)

Flags: needinfo?(jaws)
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/5c5c0f902674
Don't show import button if DisableProfileImport policy is active. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: