1676456 - For artifact builds package "rapl" as part of the common test package and make it available to "mach power"

Status: NEW

(Firefox Build System :: Bootstrap Configuration, defect, P5)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'm using an artifact build locally and would like to use the rapl binary for power measurement purposes. Sadly it's only build when you run a full build.

As such it would be great if the command would automatically fetch the binary if it's not present on disk.

Comment 1

[Andrew Overholt [:overholt]]

I don't know if this is the right component but my quick look as I try to get things out of Core: General makes me think it might be ok :)

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Huh, TIL that ./mach power exists, neat!
I think this make sense, but I'm not sure there's time on the build team to resolve this soon :(

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mitchell, maybe you can link to some examples for other tools? Maybe I can find some time in the next weeks.

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Hmm, good question.
I'd recommend taking a look at how ./mach bootstrap calls ./mach artifact to fetching things like clang.
I believe that there's "toolchain" builds in CI that create and host the packages that ./mach artifact will download, but I'm not entirely sure. Perhaps toolchains.yml is a good lead to follow?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mike, do you know if there is already an artifact for rapl as built in CI or uploaded to tooltool that we could download with a fetch task? Thanks.

Comment 6

[Mike Hommey [:glandium]]

It doesn't seem to be shipped anywhere, not even test packages. It's also currently not buildable independently of Firefox.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Mike Hommey [:glandium] from comment #6)

It doesn't seem to be shipped anywhere, not even test packages. It's also currently not buildable independently of Firefox.

Hm, is that binary something we could consider building separately? Or maybe just ship as artifact for a Firefox build? It would be kinda helpful.

Comment 8

[Mike Hommey [:glandium]]

It's too tiny to be worth building separately. Stick it in the common test package or something, and pull it from there like we take xpcshell and some other stuff from test packages.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Mike! That's a good idea. When I have the time I can have a look at it.