[wpt-sync] Sync PR 26464 - Clamp frameset cols/rows values safely to integers.
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 26464 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/26464
Details from upstream follow.
b'Morten Stenshorne <mstensho@chromium.org>' wrote:
Clamp frameset cols/rows values safely to integers.
Avoid undefined behavior, such as negative values, when casting from
double to int.Bug: 1116832
Change-Id: I49d4d5c6e73a9441d20c8a502c3d9d8cff71b7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528529
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825754}
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=394c8d5e0729fbe3ca69b0c53b820285108ee056
Assignee | ||
Comment 2•3 years ago
|
||
CI Results
Ran 14 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI
Total 6 tests
Status Summary
Firefox
FAIL: 6
Chrome
FAIL: 6
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/html/rendering/non-replaced-elements/the-frameset-and-frame-elements/large-cols-abssize.html: FAIL (Chrome: FAIL)
/html/rendering/non-replaced-elements/the-frameset-and-frame-elements/large-cols-percentage.html: FAIL (Chrome: FAIL)
/html/rendering/non-replaced-elements/the-frameset-and-frame-elements/large-cols-relsize.html: FAIL (Chrome: FAIL)
/html/rendering/non-replaced-elements/the-frameset-and-frame-elements/large-rows-abssize.html: FAIL (Chrome: FAIL)
/html/rendering/non-replaced-elements/the-frameset-and-frame-elements/large-rows-percentage.html: FAIL (Chrome: FAIL)
/html/rendering/non-replaced-elements/the-frameset-and-frame-elements/large-rows-relsize.html: FAIL (Chrome: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d008c0339df [wpt PR 26464] - Clamp frameset cols/rows values safely to integers., a=testonly https://hg.mozilla.org/integration/autoland/rev/9655d9a0b7a1 [wpt PR 26464] - Update wpt metadata, a=testonly
Comment 4•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1d008c0339df
https://hg.mozilla.org/mozilla-central/rev/9655d9a0b7a1
Description
•