1676529 - [wpt-sync] Sync PR 26467 - [LayoutNG] Find sibling spanners using the child iterator.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 26467 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26467
Details from upstream follow.

b'Morten Stenshorne <[e-mail]>' wrote:

[LayoutNG] Find sibling spanners using the child iterator.

We need to update the child iterator with where we ended up, so that the
check (after the outer loop) for whether we're at the end or not works
as intended, so that we SetHasSeenAllChildren() if we're at the end,
lest we start from the very beginning of the multicol container when
resuming layout after the spanners, which would result in an "infinite"
loop (well, until we run out of memory, anyway).

Bug: 1052834
Change-Id: I6650e9dc2c209ef6097b067344c9cff019ee4071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527139
Reviewed-by: Alison Maher \<[e-mail]>
Reviewed-by: Ian Kilpatrick \<[e-mail]>
Commit-Queue: Morten Stenshorne \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#825983}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=12042b3a7906a2e79336f9967836dbc183d22f45

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/547165e407f2
[wpt PR 26467] - [LayoutNG] Find sibling spanners using the child iterator., a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/547165e407f2