1676533 - Automatically determine "base revision" hashes during |mach artifact|

Status: RESOLVED WONTFIX

(Firefox Build System :: Mach Core, enhancement, P3)

Description

[Mitchell Hentges [:mhentges] 🦀]

As noted by bugs like 1676107, sometimes there's dirty files in-tree but it's not obvious to developers why that's causing mach artifact to fail.

As discussed in the most-recent build peers meeting, when calculating artifact hashes, we should use the state of input files as they are on the current "base revision", rather than the current state on the file system.

Comment 1

[Ricky Stewart]

Random thought: you may want to list the outgoing/changed files and only consult the VCS for THOSE files, and keep the existing logic for the unchanged files. Otherwise it's probably going to be prohibitively slow with Mercurial.

Comment 2

[Ricky Stewart]

Attachment: Bug 1676533 - Consult the base revision for file hashes instead of the on-disk files in `mach artifact`

This enables mach artifact and mach bootstrap to not fail due to local changes.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/101792a18a59
Consult the base revision for file hashes instead of the on-disk files in `mach artifact` r=ahal

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/101792a18a59

Comment 5

[Cristina Coroiu [:ccoroiu]]

Backed out on request: https://hg.mozilla.org/integration/autoland/rev/739b53fbd7214daa7c71e79c95705189c666a674

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout got merged: https://hg.mozilla.org/mozilla-central/rev/739b53fbd7214daa7c71e79c95705189c666a674

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5153f0eaf518
Consult the base revision for file hashes instead of the on-disk files in `mach artifact` r=ahal

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5153f0eaf518

Comment 9

[Atila Butkovits]

Backed out as requested: https://hg.mozilla.org/integration/autoland/rev/f4001dfef5bc1a5407956173bba6aff1ebce1760

Comment 10

[Mike Hommey [:glandium]]

It broke pushing changes to toolchain scripts to try: no toolchain builds are triggered by the decision task.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/f4001dfef5bc

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:glandium, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 13

[Mike Hommey [:glandium]]

We've been discussing an alternative option with Alex, which is to use the latest central decision task graph. I'm not sure there's a bug on file about that, but this is not the one, and I don't think we're going to implement this.