1676726 - android testing: make 'logcat -c' failures non-fatal

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement, P1)

Description

[Andrew Erickson [:aerickson]]

Seen when testing on a Samsung S7 Galaxy (root disabled).

[task 2020-11-11T20:07:53.578Z] 20:07:37     INFO -  adb Unable to set SELinux Permissive due to args: adb wait-for-device shell setenforce Permissive, exitcode: 1, stdout: setenforce: Couldn't set enforcing status to 'Permissive': Permission denied.
[task 2020-11-11T20:07:53.578Z] 20:07:37     INFO -  adb Setting run_as_package to org.mozilla.geckoview.test
[task 2020-11-11T20:07:53.578Z] 20:07:38     INFO -  adb Setting test_root to /data/local/tmp/test_root
[task 2020-11-11T20:07:53.578Z] 20:07:39     INFO -  adb Resetting test root from /data/local/tmp/test_root to /data/data/org.mozilla.geckoview.test/test_root
[task 2020-11-11T20:07:53.578Z] 20:07:47     INFO -  adb retryable logcat clear error?: args: adb wait-for-device logcat -c, exitcode: 1, stdout: failed to clear the 'main' log. Retrying...
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -  Traceback (most recent call last):
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -    File "/builds/task_160512508566863/workspace/build/tests/mochitest/runtestsremote.py", line 397, in <module>
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -      sys.exit(main())
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -    File "/builds/task_160512508566863/workspace/build/tests/mochitest/runtestsremote.py", line 393, in main
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -      return run_test_harness(parser, options)
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -    File "/builds/task_160512508566863/workspace/build/tests/mochitest/runtestsremote.py", line 355, in run_test_harness
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -      mochitest = MochiRemote(options)
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -    File "/builds/task_160512508566863/workspace/build/tests/mochitest/runtestsremote.py", line 84, in __init__
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -      self.device.clear_logcat()
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -    File "/builds/task_160512508566863/workspace/build/venv/lib/python2.7/site-packages/mozdevice/adb.py", line 1977, in clear_logcat
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -      self.command_output(cmds, timeout=timeout)
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -    File "/builds/task_160512508566863/workspace/build/venv/lib/python2.7/site-packages/mozdevice/adb.py", line 1495, in command_output
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -      self, cmds, device_serial=self._device_serial, timeout=timeout
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO -    File "/builds/task_160512508566863/workspace/build/venv/lib/python2.7/site-packages/mozdevice/adb.py", line 343, in command_output
[task 2020-11-11T20:07:53.578Z] 20:07:53 CRITICAL -      raise ADBProcessError(adb_process)
[task 2020-11-11T20:07:53.578Z] 20:07:53 CRITICAL -  mozdevice.adb.ADBProcessError: args: adb wait-for-device logcat -c, exitcode: 1, stdout: failed to clear the 'main' log
[task 2020-11-11T20:07:53.578Z] 20:07:53    ERROR - Return code: 1
[task 2020-11-11T20:07:53.578Z] 20:07:53    ERROR - No tests run or test summary not found
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO - TinderboxPrint: mochitest-media<br/><em class="testfail">T-FAIL</em>
[task 2020-11-11T20:07:53.578Z] 20:07:53     INFO - ##### mochitest-media log ends
[task 2020-11-11T20:07:53.578Z] 20:07:53 CRITICAL - # TBPL RETRY #
[task 2020-11-11T20:07:53.578Z] 20:07:53  WARNING - setting return code to 4
[task 2020-11-11T20:07:53.578Z] 20:07:53 CRITICAL - The mochitest-media suite: mochitest-media ran with return status: RETRY

Comment 1

[Bob Clary [:bc] (inactive)]

I'll get to this later today.

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: Bug 1676726 - [mozdevice] Do not raise an error if adb logcat -c fails., r=aerickson.

Depends on D97571

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2eb666b60ac
[mozdevice] Do not raise an error if adb logcat -c fails., r=aerickson.

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a2eb666b60ac