Closed
Bug 1676768
Opened 4 years ago
Closed 4 years ago
Fix some unified build failures in widget/android
Categories
(Core Graveyard :: Widget: Android, task)
Core Graveyard
Widget: Android
Tracking
(firefox84 fixed)
RESOLVED
FIXED
84 Branch
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
Details
Attachments
(3 files)
Adding a cpp file to widget/android causes some build failures at the moment.
Assignee | ||
Comment 1•4 years ago
|
||
This only happened to work because unified build included WebAuthnTokenManager.cpp
and nsAppShell.cpp into the same compilation unit.
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D96792
Assignee | ||
Comment 3•4 years ago
|
||
Depends on D96793
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/89c8b4e18ab2 Move WebAuthnTokenManager class definition into a header file, because nsAppShell.cpp calls WebAuthnTokenManager::Init(). r=geckoview-reviewers,snorp https://hg.mozilla.org/integration/autoland/rev/fc6dfec1a09e Add some missing includes. r=geckoview-reviewers,snorp https://hg.mozilla.org/integration/autoland/rev/b7f5466d0d3b Add some missing gfx:: namespace annotations in nsWindow.cpp. r=geckoview-reviewers,snorp
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/89c8b4e18ab2
https://hg.mozilla.org/mozilla-central/rev/fc6dfec1a09e
https://hg.mozilla.org/mozilla-central/rev/b7f5466d0d3b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•