167682 - Save dialog has problems when choosing directory

Status: VERIFIED DUPLICATE of bug 130477

(Core :: XUL, defect)

Description

[Jan Kozanek]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020827
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020827

When you want to save i.e. a page as a file and in the "Save As" window
double-click the folder at the very bottom of the current view, Mozilla falsely
identifies your double-click as 2 separate mouse clicks. It then scrolls the
view and then enters a completely different directory as a result of the second
click. 

Reproducible: Always

Steps to Reproduce:
This bug repeats since Mozila 0.99 as far as i remember.
Actual Results:  
as explained in details

Expected Results:  
Mozilla should definitely enter the directory you double-click at regardless of
the folder orientation in the current view.

Comment 1

[Christopher Curzio]

Confirmed on Linux (Build ID: #2002090922)

On the second click, the dialog actually recognizes *both* the single and double
click. It recognizes the single click by highlighting the next entry in the
list, THEN it recognizes the double-click by actually entering that directory.

Note: You need to be browsing a directory tree that requires you to scroll. Try /.

Comment 2

[Jan Kozanek]

Correct. In fact what is happening, is that a single mouse click forcing the
directory browser to scroll down has a precedence over the double-click.

The functions should be swapped in their order: FIRST to distinguish whether
we've to deal with a double-click, if YES, then go and enter the selected directory.

If NO, scroll the view down.

Comment 3

[Matthias Versen [:Matti]]

-> File Handling

Comment 4

[Jan Kozanek]

Just gave it a try and reproduced exactly on Mozilla/5.0 (X11; U; Linux i686;
en-US; rv:1.6) Gecko/20040113

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 199861 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

Neil, any way to make this happier?  Can this be done in the filepicker, or does
the tree code need fixing?

Comment 7

[[e-mail]]

The tree click code likes to make the clicked-on row visible, so if it's
partially obscured it will scroll the row up. I tried it with my custom tree
demo, and if I double-click the obscured row it is in fact the row below that
will expand, so the tree's internal double-click handler has the same bug.
Jan, I suggest a) clickcount="1" on the treebody mousedown/click handlers and b)
using currentIndex in the tree's own doubleclick handler, does that sound OK?

Comment 8

[Jan Varga [:janv]]

Sounds like bug 130477

Comment 9

[Jan Kozanek]

Correct, this is a dupe of Bug 130477

Sorry for not originally finding it.

Besides, what Boris in #7 says, is to my opinion the best approach. Since we
won't have to let any timeouts to pass. If the click is just single, file picker
scrolls immediately. If it's followed by another click thus becoming a
double-click the previously highlighted and scrolled-up dir is entered immediately.

The only issue here could be a flicker this scroll-up followed by a complete
folder view redraw might produce. Something as described in Bug 143663


*** This bug has been marked as a duplicate of 130477 ***

Comment 10

[Boris Zbarsky [:bzbarsky]]

Verified, I guess.... I'd left this open because it had more info than bug 130477...

And Neil's the one that made comment 7.