Closed
Bug 1676837
Opened 4 years ago
Closed 3 years ago
[PipeWire] Specify supported buffer dataTypes and modifier used for pipewire screencast
Categories
(Core :: WebRTC, enhancement)
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: co1umbarius, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
2.69 KB,
patch
|
Details | Diff | Splinter Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0
Steps to reproduce:
- Start screencast with pipewire on wayland
- Look at the port parameters with pw-cli
Actual results:
- No SPA_PARAM_BUFFERS_dataType is set
- No SPA_FORMAT_VIDEO_modifier is set
Expected results:
- SPA_PARAM_BUFFERS_dataType should be set to announce MemPtr, MemFd and DmaBuf
- SPA_FORMAT_VIDEO_modifer should be set to 0 if dmabufs are still mmaped.
|
Reporter | |
Comment 1•4 years ago
|
||
The attached patch is a patch for the upstreamed pipewire patches from fedora.
|
|
Reporter | |
Updated•4 years ago
|
OS: Unspecified → Linux
|
|
Reporter | |
Updated•4 years ago
|
Component: Untriaged → WebRTC: Audio/Video
Product: Firefox → Core
|
|
Reporter | |
Comment 2•4 years ago
|
||
These parameters are important for the screencast portal provider and pipewire to correctly detect the clients capabilities.
|
Assignee | |
Updated•4 years ago
|
Blocks: pipewire
Component: WebRTC: Audio/Video → WebRTC
Summary: Specify supported buffer dataTypes and modifier used for pipewire screencast → [PipeWire] Specify supported buffer dataTypes and modifier used for pipewire screencast
|
|
Assignee | |
Comment 3•4 years ago
|
||
I'll submit the patch to phabricator for review, Thanks.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Patch created by co1umbarius at protonmail.com
|
||
Updated•3 years ago
|
Assignee: nobody → stransky
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/71138e0818ed [Wayland] Specify supported buffer dataTypes and modifier used for pipewire screencast, r=ng
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•