Open Bug 1676852 Opened 10 months ago Updated 10 months ago

Investigate if RefreshDriver run on idle queue should update mLastFireTime sooner

Categories

(Core :: Layout, task)

task

Tracking

()

REOPENED

People

(Reporter: smaug, Assigned: smaug, NeedInfo)

References

Details

(Keywords: perf-alert)

Attachments

(1 obsolete file)

During page load some RefreshDriver ticks are using idle queue. That behavior improves pageload on some animationframe heavy sites.
But it seems that idle detection might be a bit wrong if mLastFireTime isn't updated on time. Investigating.

(The behavior isn't new.)

Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f488d4345f75
Investigate if RefreshDriver run on idle queue should update mLastFireTime sooner, r=farre
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Flags: needinfo?(bugs)

Backed out changeset f488d4345f75 (bug 1676852) as per dev's request. a=backout

Backout on beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/c5c6b7ec0fe5d5a0d8ff67cfafe333ae9e86a7c5

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 84 Branch → ---
Attachment #9187557 - Attachment is obsolete: true

== Change summary for alert #27809 (as of Mon, 23 Nov 2020 05:27:11 GMT) ==

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
4% youtube linux64-shippable-qr cold nocondprof webrender 815.86 -> 850.20
2% youtube linux64-shippable-qr cold nocondprof webrender 825.37 -> 841.20

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27809

You need to log in before you can comment on or make changes to this bug.