1676852 - Investigate if RefreshDriver run on idle queue should update mLastFireTime sooner

Status: RESOLVED WONTFIX

(Core :: Layout, task)

Description

[Olli Pettay [:smaug][[e-mail]]]

During page load some RefreshDriver ticks are using idle queue. That behavior improves pageload on some animationframe heavy sites.
But it seems that idle detection might be a bit wrong if mLastFireTime isn't updated on time. Investigating.

(The behavior isn't new.)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=55f6476f68d5cc0f57ad5aa110e9213606dc3fba

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1676852 - Investigate if RefreshDriver run on idle queue should update mLastFireTime sooner, r=farre

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f488d4345f75
Investigate if RefreshDriver run on idle queue should update mLastFireTime sooner, r=farre

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f488d4345f75

Comment 5

[Cristina Coroiu [:ccoroiu]]

Backed out on request by smaug

Backout: https://hg.mozilla.org/integration/autoland/rev/2a64437827b9ee4c8d492ba7671cd6489cffc25c

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset f488d4345f75 (bug 1676852) as per dev's request. a=backout

Backout on beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/c5c6b7ec0fe5d5a0d8ff67cfafe333ae9e86a7c5

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/2a64437827b9ee4c8d492ba7671cd6489cffc25c

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #27809 (as of Mon, 23 Nov 2020 05:27:11 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	youtube		linux64-shippable-qr	cold nocondprof webrender	815.86 -> 850.20
2%	youtube		linux64-shippable-qr	cold nocondprof webrender	825.37 -> 841.20

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27809

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 10

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Closing this old investigation. I have done other tweaks and will do more :)