1676865 - Intermittent comm/mail/test/browser/openpgp/browser_keyWizard.js | uncaught exception - TypeError: can't access property "resizeVertically", gSubDialog._topDialog is undefined at resizeDialog/<@chrome://openpgp/content/ui/keyWizard.js:533:7

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=321553429&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RawiaY91Tx69DsBpeRPewQ/runs/0/artifacts/public/logs/live_backing.log

---

Don't think I saw it before https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=RawiaY91Tx69DsBpeRPewQ.0&revision=1104390ebf76c917b35d2fbee3a9f31a62ac92c2```

Comment 1

[Magnus Melin [:mkmelin]]

Seems to be a common issue on OSX

Comment 2

[Alessandro Castellani [:aleca]]

Thanks for the ping, I'll take care of it.

Comment 3

[Intermittent Failures Robot]

4 failures in 4040 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 4

Platform breakdown:

• macosx1014-64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1676865&startday=2020-11-09&endday=2020-11-15&tree=all

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1676865-keywizard-test.diff

Very hard to reproduce locally as it seems to be related to an issue only happening when the test runs quicker than the transition timeout and closes the subdialog before the resizeDialog() got a chance to run.

This should fix it.
We could implement a smarter way waiting for the transition to end and the resize to happen, but that means delaying the test unnecessarily.
Do you think we should do that?

Meanwhile, here's a try run with the current patch: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=6ab54522622c626a98439f74d828d6f0723a0472

Comment 5

[Alessandro Castellani [:aleca]]

I forgot the macOS tests don't run if I only pick mochitests.
I launched another try-run with all the tests, just to be sure we're not breaking anything else: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=2183bdf6c3d0e4690c0c5240d6eca78d74c59b5d

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9188196 [details] [diff] [review]
1676865-keywizard-test.diff

Still failing, I'll try another solution.

Comment 7

[Alessandro Castellani [:aleca]]

Maybe the issue is not the test or the KeyWizard itself but rather the RNP library not running on treeherder?
https://treeherder.mozilla.org/logviewer?job_id=322006631&repo=try-comm-central&lineNumber=3197-3198

Nevermind, the RNP library doesn't load with artifact builds, that's why everything was failing.

Comment 8

[Magnus Melin [:mkmelin]]

Yeah mac artifacts not working with rnp is bug 1675160.

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9188196 [details] [diff] [review]
1676865-keywizard-test.diff

Review of attachment 9188196 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/extensions/openpgp/content/ui/keyWizard.js
@@ +527,2 @@
>  function resizeDialog() {
>    // Timeout to trigger the dialog resize after the reveal animation completed.

Well you do have the transitionend event, so maybe hook up to that?

I'll also note there seems to be a lot of eventListener setup+removals for that event here. If it's just going to be used once, just pass in the { once: true } option to addEventListener instead, could make the code easier to undestand

Comment 10

[Alessandro Castellani [:aleca]]

Attachment: 1676865-keywizard-test.diff

Try run seems good: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=5f7e927949bf176486bfb60e064a38df36f56b12

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 9188943 [details] [diff] [review]
1676865-keywizard-test.diff

Review of attachment 9188943 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a141d1237293
Fix intermittent comm/mail/test/browser/openpgp/browser_keyWizard.js test failure. r=mkmelin

Comment 13

[Intermittent Failures Robot]

1 failures in 4810 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform breakdown:

• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1676865&startday=2020-11-16&endday=2020-11-22&tree=all

Comment 14

[Kai Engert (:KaiE:)]

Should this get uplifted to 84 beta?

Comment 15

[Magnus Melin [:mkmelin]]

Comment on attachment 9188943 [details] [diff] [review]
1676865-keywizard-test.diff

Review of attachment 9188943 [details] [diff] [review]:
-----------------------------------------------------------------

Fix intermittent test failure on beta.

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9188943 [details] [diff] [review]
1676865-keywizard-test.diff

[Triage Comment]
Approved for beta

Comment 17

[Kai Engert (:KaiE:)]

I think I saw this one on esr78 today with a local build. I suggest to target an uplift to esr78, too.

Comment 18

[Dave Miller [:justdave]]

Thunderbird 84.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/25ed583dc78d

Comment 19

[Kai Engert (:KaiE:)]

saw this again in a local build

Comment 20

[Kai Engert (:KaiE:)]

are we ready to request esr78 approval?

Comment 21

[Alessandro Castellani [:aleca]]

(In reply to Kai Engert (:KaiE:) from comment #20)

are we ready to request esr78 approval?

Yes, I'll do that, I was waiting for the beta release and potential intermittent issues there.

Comment 22

[Alessandro Castellani [:aleca]]

Comment on attachment 9188943 [details] [diff] [review]
1676865-keywizard-test.diff

[Approval Request Comment]
Fix intermittent test failure on esr 78.

Comment 23

[Wayne Mery (:wsmwk)]

Comment on attachment 9188943 [details] [diff] [review]
1676865-keywizard-test.diff

[Triage Comment]
Approved for esr78

Comment 24

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-esr78/rev/fbbde0f9bf811cb281cb2d2a5456e1023be54975
78.5.1