Closed
Bug 1676885
Opened 3 years ago
Closed 3 years ago
Remove async keyword from backupSecretKeysInteractive()
Categories
(MailNews Core :: Security: OpenPGP, task)
MailNews Core
Security: OpenPGP
Tracking
(thunderbird_esr78 wontfix)
RESOLVED
FIXED
85 Branch
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | wontfix |
People
(Reporter: lasana, Assigned: lasana)
Details
Attachments
(1 file)
3.34 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
This function is marked as async but does not await anything or return any Promises. It also accepts a callback to report results. This could be replaced by returning a tuple instead.
https://searchfox.org/comm-central/source/mail/extensions/openpgp/content/modules/keyRing.jsm#586
Assignee | ||
Comment 1•3 years ago
|
||
Actually nothing in this function is async. Opening the dialog blocks.
Assignee | ||
Comment 2•3 years ago
|
||
Removed the async keyword, also made the work of the callback part of backupKeysInteractive()
. Does not seem like the function is used anywhere else and it already opens a dialog internally.
Attachment #9188579 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Updated•3 years ago
|
Summary: Make backupSecretKeysInteractive() function actually async. → Remove async keyword from backupSecretKeysInteractive()
Assignee | ||
Updated•3 years ago
|
Status: NEW → ASSIGNED
Comment 3•3 years ago
|
||
Comment on attachment 9188579 [details] [diff] [review] bug1676885.patch Review of attachment 9188579 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9188579 -
Flags: review?(mkmelin+mozilla) → review+
Updated•3 years ago
|
status-thunderbird_esr78:
--- → wontfix
Target Milestone: --- → 85 Branch
Assignee | ||
Updated•3 years ago
|
Keywords: checkin-needed-tb
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/73214389c936
Remove async keyword from backupSecretInteractive(). r=mkmelin
You need to log in
before you can comment on or make changes to this bug.
Description
•