Closed Bug 1676885 Opened 3 years ago Closed 3 years ago

Remove async keyword from backupSecretKeysInteractive()

Categories

(MailNews Core :: Security: OpenPGP, task)

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
85 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: lasana, Assigned: lasana)

Details

Attachments

(1 file)

This function is marked as async but does not await anything or return any Promises. It also accepts a callback to report results. This could be replaced by returning a tuple instead.

https://searchfox.org/comm-central/source/mail/extensions/openpgp/content/modules/keyRing.jsm#586

Actually nothing in this function is async. Opening the dialog blocks.

Attached patch bug1676885.patchSplinter Review

Removed the async keyword, also made the work of the callback part of backupKeysInteractive(). Does not seem like the function is used anywhere else and it already opens a dialog internally.

Attachment #9188579 - Flags: review?(mkmelin+mozilla)
Summary: Make backupSecretKeysInteractive() function actually async. → Remove async keyword from backupSecretKeysInteractive()
Status: NEW → ASSIGNED
Comment on attachment 9188579 [details] [diff] [review]
bug1676885.patch

Review of attachment 9188579 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9188579 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → 85 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/73214389c936
Remove async keyword from backupSecretInteractive(). r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: