Add initialization function to OpenPGPTestUtils to ensure OpenPGP is available in xpcshell tests.
Categories
(MailNews Core :: Security: OpenPGP, task)
Tracking
(thunderbird_esr78 affected)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | affected |
People
(Reporter: lasana, Assigned: lasana)
References
Details
Attachments
(2 files)
OpenPGP is initialized automatically in browser tests, for xpcshell tests we need to run the initialization steps manually.
Assignee | ||
Updated•2 months ago
|
Assignee | ||
Comment 1•2 months ago
|
||
Method added.
Assignee | ||
Comment 2•2 months ago
|
||
Updated•2 months ago
|
Updated•2 months ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1b59f646aea5
Add initOpenPGP() method to OpenPGPTestUtils for xpcshell tests. r=mkmelin
Assignee | ||
Comment 4•2 months ago
|
||
Comment on attachment 9187677 [details] [diff] [review]
bug1676887.patch
[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: Minimal, this is for tests.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): Minimal, this adds a convenience function to OpenPGPTestUtils
Comment 5•1 month ago
|
||
Comment on attachment 9187677 [details] [diff] [review]
bug1676887.patch
[Triage Comment]
Dependency for bug 1677508 and only changes test code, so minimal risk and allows for increased test coverage of OpenPGP.
Comment 6•1 month ago
|
||
bugherderuplift |
Thunderbird 78.6.0:
https://hg.mozilla.org/releases/comm-esr78/rev/a42f6b01be9b
Comment 7•1 month ago
|
||
Uplift to esr78 broke tests:
ERROR Unexpected exception TypeError: EnigmailKeyRing.init is not a function at resource://testing-common/mozmill/OpenPGPTestUtils.jsm:49
Comment 8•1 month ago
|
||
Function EnigmailKeyRing.init was added in bug 1664700 which is wontfix for esr78.
I suggest to remove the call to EnigmailKeyRing.init on esr78.
Comment 9•1 month ago
|
||
Comment 10•1 month ago
|
||
Commit for attempted bustage fix was:
https://hg.mozilla.org/releases/comm-esr78/rev/af27ebca17f9bcdf46f09e7e1f63818210507bcd
Both patches backed out from 78.x:
https://hg.mozilla.org/releases/comm-esr78/rev/068dfd26c5d334bac8473c110934be67e2351b7d
Comment 11•3 days ago
|
||
Comment on attachment 9187677 [details] [diff] [review]
bug1676887.patch
Resetting the approval status as there's no clear direction what the next step is for comm-esr78.
Description
•