1676887 - Add initialization function to OpenPGPTestUtils to ensure OpenPGP is available in xpcshell tests.

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, task)

Description

[Lasana Murray]

OpenPGP is initialized automatically in browser tests, for xpcshell tests we need to run the initialization steps manually.

Comment 1

[Lasana Murray]

Attachment: bug1676887.patch

Method added.

Comment 2

[Lasana Murray]

Try run mostly green:

https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=d4c9238aa36a7b2f5317f8f03f0fb027f26c079a

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1b59f646aea5
Add initOpenPGP() method to OpenPGPTestUtils for xpcshell tests. r=mkmelin

Comment 4

[Lasana Murray]

Comment on attachment 9187677 [details] [diff] [review]
bug1676887.patch

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: Minimal, this is for tests.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): Minimal, this adds a convenience function to OpenPGPTestUtils

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9187677 [details] [diff] [review]
bug1676887.patch

[Triage Comment]
Dependency for bug 1677508 and only changes test code, so minimal risk and allows for increased test coverage of OpenPGP.

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.6.0:
https://hg.mozilla.org/releases/comm-esr78/rev/a42f6b01be9b

Comment 7

[Kai Engert (:KaiE:)]

Uplift to esr78 broke tests:

ERROR Unexpected exception TypeError: EnigmailKeyRing.init is not a function at resource://testing-common/mozmill/OpenPGPTestUtils.jsm:49

Comment 8

[Kai Engert (:KaiE:)]

Function EnigmailKeyRing.init was added in bug 1664700 which is wontfix for esr78.

I suggest to remove the call to EnigmailKeyRing.init on esr78.

Comment 9

[Kai Engert (:KaiE:)]

Attachment: Bug 1676887 - Bustage fix for esr78. rs=bustage a=bustage

Comment 10

[Kai Engert (:KaiE:)]

Commit for attempted bustage fix was:
https://hg.mozilla.org/releases/comm-esr78/rev/af27ebca17f9bcdf46f09e7e1f63818210507bcd

Both patches backed out from 78.x:
https://hg.mozilla.org/releases/comm-esr78/rev/068dfd26c5d334bac8473c110934be67e2351b7d

Comment 11

[Rob Lemley [:rjl]]

Comment on attachment 9187677 [details] [diff] [review]
bug1676887.patch

Resetting the approval status as there's no clear direction what the next step is for comm-esr78.

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/01ac7c5c1769

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/e6a95c2014e2