Closed Bug 1676887 Opened 10 months ago Closed 10 months ago

Add initialization function to OpenPGPTestUtils to ensure OpenPGP is available in xpcshell tests.

Categories

(MailNews Core :: Security: OpenPGP, task)

Tracking

(thunderbird_esr78 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
thunderbird_esr78 --- fixed

People

(Reporter: lasana, Assigned: lasana)

References

Details

Attachments

(2 files)

OpenPGP is initialized automatically in browser tests, for xpcshell tests we need to run the initialization steps manually.

Status: NEW → ASSIGNED
Attached patch bug1676887.patchSplinter Review

Method added.

Attachment #9187677 - Flags: review?(mkmelin+mozilla)
Attachment #9187677 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → 84 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1b59f646aea5
Add initOpenPGP() method to OpenPGPTestUtils for xpcshell tests. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Blocks: 1677508

Comment on attachment 9187677 [details] [diff] [review]
bug1676887.patch

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: Minimal, this is for tests.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): Minimal, this adds a convenience function to OpenPGPTestUtils

Attachment #9187677 - Flags: approval-comm-esr78?

Comment on attachment 9187677 [details] [diff] [review]
bug1676887.patch

[Triage Comment]
Dependency for bug 1677508 and only changes test code, so minimal risk and allows for increased test coverage of OpenPGP.

Attachment #9187677 - Flags: approval-comm-esr78? → approval-comm-esr78+

Uplift to esr78 broke tests:

ERROR Unexpected exception TypeError: EnigmailKeyRing.init is not a function at resource://testing-common/mozmill/OpenPGPTestUtils.jsm:49

Function EnigmailKeyRing.init was added in bug 1664700 which is wontfix for esr78.

I suggest to remove the call to EnigmailKeyRing.init on esr78.

Comment on attachment 9187677 [details] [diff] [review]
bug1676887.patch

Resetting the approval status as there's no clear direction what the next step is for comm-esr78.

Attachment #9187677 - Flags: approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.