Closed Bug 1676903 Opened 3 years ago Closed 3 years ago

Turn off global English feed for now

Categories

(Firefox :: New Tab Page, defect)

defect

Tracking

()

VERIFIED FIXED
84 Branch
Tracking Status
firefox84 + verified

People

(Reporter: thecount, Assigned: thecount)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

We've done some experimenting with a global English feed of Pocket stories on newtab, but for now we're going to turn this off.

Likely make it so it's only on in nightly until we're ready to turn it back on.

[Tracking Requested - why for this release]:

Assignee: nobody → sdowne
Blocks: 1660035

This should change for nightly, so kinda hard to QA.

If you want to see what this would look like in beta/release, just follow these steps:

  1. Use an English browser
  2. Set browser.search.region to IT
  3. Set browser.newtabpage.activity-stream.discoverystream.locale-list-config to ""
  4. Restart
  5. Open a new tab

Expected: should not see pocket stories.

Attachment #9187406 - Attachment is obsolete: true
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/ecd65e2954c1
Turn off global English newtab Pocket stories outside of nightly r=gvn
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

I have verified the following using Firefox Nightly 84.0a1 (Build ID: 20201116094341) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:

  1. If the "browser.search.region" pref value is set to "IT" the "Recommended by Pocket" en feed 3x7 is correctly displayed.
  2. The "Recommended by Pocket" en feed 3x7 is correctly displayed for RO region by default.
  3. If the "browser.search.region" pref value is set to "FR" the "Recommended by Pocket" section is NOT displayed.

@Scott, can you please let me know if 3 is still expected behavior, after the latest feature changes?

Flags: needinfo?(sdowne)

@Robert, hey, I could have probably been more clear about this, my bad.

Step 3 applies only for nightly.

We decided to keep the global feed on in nightly for the time being, but turn it off in release/beta.

So the steps you have in your previous comment are correct and still apply to nightly.

Once 84 hits beta, the steps should be different. Also once 84 hits beta, step 3 no longer applies because "FR" is off, which means the global override off is redundant.

Steps to test this once it's in beta are:

  1. Use an English browser
  2. Set browser.search.region to IT
  3. Restart
  4. Open a new tab

Expected: should not see pocket stories.

If you were to flip this pref browser.newtabpage.activity-stream.discoverystream.locale-list-config to "" in nightly, you would simulate what's different between nightly/beta.

Hope that helps.

let me know if you have more questions, happy to continue this.

Flags: needinfo?(sdowne)

Hey @Scott,

Thank you for the clarification!

I can confirm the following using Firefox Nightly 84.0a1 (Build ID: 20201116094341) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:

  • The "Recommended by Pocket" section is correctly displayed on "RO" and "IT" regions.
  • The "Recommended by Pocket" section is NOT displayed on "FR" region.

I can also confirm the following using Firefox 83 RC (Build ID: 20201112153044) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:

  • The "Recommended by Pocket" section is NOT displayed on "RO", "IT", and "FR" regions.

@Scott, do you think that this is enough verification in order to mark the issue as VERIFIED, or I should wait for 84 to land in Firefox Beta and do another round of verification?

@Robert, Waiting for 84 to land in beta, and then testing, would be correct. This is because the current 83 beta isn't testing the same mechanism for this as the 84 beta would. Enough has changed to warrant a quite verification, imo.

Thank you @Scott!
I will leave myself a NI in order to come back and verify this once Firefox Beta 84.0b1 is available.

Flags: needinfo?(romartin)

I have verified that the "Recommended by Pocket" section is NOT displayed on "IT" and "RO" section by following the steps provided in comment 8 using Firefox 84.0b2 (Build ID: 20201117192430) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64.

Given the above, and the verification done and mentioned in comment 9 I'm marking this issue as VERIFIED.

Status: RESOLVED → VERIFIED
Flags: needinfo?(romartin)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: