1676910 - With Windows High Contrast theme black and TB default theme, no visual indication of recipient pills (which irritatingly makes them look like plain text)

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[jhudson]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

Reply all; went to edit out receipients that shouldn't receive it

Actual results:

had a hard time of it because everything's on one line; looks like a textbox but isn't

Expected results:

the tag-like buttons should have had an outline or something; it looks like you want to spot a cursor between them but that does something else as "between them" is the border of a bunch of hitboxes

Comment 1

[Wayne Mery (:wsmwk)]

I don't understand where the problem is. At least on Mac, mousing over any address pill highlights it and provides and outline. And click a pill selects it. I believe the same is true on Windows.
Reference https://support.mozilla.org/en-US/kb/thunderbird-78-faq#w_when-writing-a-new-message-how-can-i-add-edit-or-remove-recipients-in-thunderbird-78

What precisely is the difficulty?

Comment 2

[jhudson]

Attachment: noaffordance.png

Comment 3

[jhudson]

This looks like a textbox but sure doesn't act like one. This isn't a game. Never depend on mouse move events. They get stripped away for latency.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1676910-HC-pills.patch

This patch gives the pills a border in Highlight colour. When hovering/selecting the pill it looks like the normal buttons.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: HC-pill.png

This is how the pills would look: above the unselected pill and below the hovered/selected pill.

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9193571 [details]
HC-pill.png

This looks good.
Will this problem happen only on Windows? Is this a OS theme or Thunderbird theme?
Can I see the variations for hover and focus status with multiple pills?

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #6)

Comment on attachment 9193571 [details]
HC-pill.png

This looks good.
Will this problem happen only on Windows? Is this a OS theme or Thunderbird theme?
Can I see the variations for hover and focus status with multiple pills?

This is with the Windows 10 high contrast theme.

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9193570 [details] [diff] [review]
1676910-HC-pills.patch

Thomas, it seems John has no time. Could you review this patch?

Comment 9

[John Bieling (:TbSync)]

What settings do I have to activate to view the change?

Comment 10

[jhudson]

Windows: enable High Contrast Black
Instructions: https://support.microsoft.com/en-us/windows/turn-high-contrast-mode-on-or-off-in-windows-909e9d89-a0f9-a3a9-b993-7a6dcee85025

Comment 11

[Richard Marti (:Paenglab)]

Only a Windows 10 High Contrast theme is needed.

Comment 12

[John Bieling (:TbSync)]

Ok, my system is building, will check this ASAP.

Comment 13

[Thomas D. (:thomas8)]

Comment on attachment 9193570 [details] [diff] [review]
1676910-HC-pills.patch

Review of attachment 9193570 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately, this isn't quite right in several ways. As Alex mentioned, we must ensure to handle cases like "focused, but not selected" correctly.

- Please don't use green highlight color for non-focused or non-selected things. 
- Border of unselected, unfocused fill should be whitish just like the address row border. It's not very important, just needs to be visible. Green attracts far too much attention, and pretends it's focused, which it is not.
- focused *unselected* pill does not look any different from focused *selected* pill - that's a recipe for disaster!
- For focused *unselected* pill, let's just try green highlight focus border.
- I think the hover effect is too strong, and again prone to mixup with selection. What if we try whitish background on hover with black text, or perhaps highlight border without background change?
- Hovering pill makes the "unknown to AB" indicator dot disappear and should not.

Comment 14

[Thomas D. (:thomas8)]

I humbly suggest having descriptive and understandable summaries before we start working on a bug.

Comment 15

[Richard Marti (:Paenglab)]

Attachment: 1676910-HC-pills.patch

(In reply to Thomas D. (:thomas8) from comment #13)

Comment on attachment 9193570 [details] [diff] [review]
1676910-HC-pills.patch

Review of attachment 9193570 [details] [diff] [review]:

Unfortunately, this isn't quite right in several ways. As Alex mentioned, we
must ensure to handle cases like "focused, but not selected" correctly.

• Please don't use green highlight color for non-focused or non-selected
  things.
• Border of unselected, unfocused fill should be whitish just like the
  address row border. It's not very important, just needs to be visible. Green
  attracts far too much attention, and pretends it's focused, which it is not.

done

• focused unselected pill does not look any different from focused
  selected pill - that's a recipe for disaster!

should be better. But high contrast is so limited, not enough colours.

• For focused unselected pill, let's just try green highlight focus border.

should be better.

• I think the hover effect is too strong, and again prone to mixup with
  selection. What if we try whitish background on hover with black text, or
  perhaps highlight border without background change?

should be better.

• Hovering pill makes the "unknown to AB" indicator dot disappear and should
  not.

should be better.

Comment 16

[Thomas D. (:thomas8)]

Comment on attachment 9196136 [details] [diff] [review]
1676910-HC-pills.patch

Review of attachment 9196136 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks! This addresses the problems found in my review of Comment 13.

Comment 17

[Thomas D. (:thomas8)]

Attachment: Screenshot: attachment 9196136 applied. Second pill is focus or hover.

Nice. Alessandro's "Unknown address" indicator is also pretty cool!

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/28f7d44f9ff5
Make the pills visible on Windows high contrast themes. r=thomas8

Comment 19

[Richard Marti (:Paenglab)]

But this affects ESR too and the patch can be applied as it is.

Comment 20

[Magnus Melin [:mkmelin]]

Oh, if you want, and it's not tied into a lot of dependencies, we can probably take it. (Request approvals as needed.)

Comment 21

[Richard Marti (:Paenglab)]

Comment on attachment 9196136 [details] [diff] [review]
1676910-HC-pills.patch

[Approval Request Comment]
User impact if declined: with Win 10 HC theme the pill isn't visible when not selected
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

I'm asking for approval-beta as it's possible where will be one built again.

Comment 22

[Wayne Mery (:wsmwk)]

Comment on attachment 9196136 [details] [diff] [review]
1676910-HC-pills.patch

[Triage Comment]
Approved for esr78

Comment 23

[Dave Miller [:justdave]]

Thunderbird 78.7.0:
https://hg.mozilla.org/releases/comm-esr78/rev/b1bef3d19ecf

Comment 24

[Dave Miller [:justdave]]

The patch on esr78 failed tests when it built. See bug 1688693, need a patch for this ASAP, 78.7.0 will hold for it.