Quickfilter bar buttons disappear when hovered over (with Windows 10 High Contrast Theme Black and TB default theme)
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird_esr78 verified)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | verified |
People
(Reporter: jhudson, Assigned: Paenglab)
Details
(Whiteboard: ESR only issue)
Attachments
(2 files, 1 obsolete file)
7.31 KB,
image/png
|
Details | |
1.19 KB,
patch
|
thomas8
:
review+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0
Steps to reproduce:
Hovered over filter by has attached button
Actual results:
the button disappeared
Expected results:
the button should have been highlighted
Comment 1•4 years ago
|
||
you are using the dark theme?
Theme is still default. OS colors are High Contrast Black.
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Alessandro, I know you have no Windows but this is a one-liner. It adds only the QFB bar to the High Contrast button variables.
This is a ESR only bug. On Daily it works after all my cleanup works.
Comment 4•4 years ago
|
||
Better to ping Thomas or John for this Windows specific review.
From a pure CSS point of view it looks good to me.
Assignee | ||
Comment 5•4 years ago
|
||
John, please can you review this patch?
Updated•4 years ago
|
Updated•4 years ago
|
Comment 6•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
Comment on attachment 9193569 [details] [diff] [review]
1676911-hc-qfb-button.patch
[Approval Request Comment]
User impact if declined: on Win 10 high contrast unreadable QFB buttons
Testing completed (on c-c, etc.): ESR only issue
Risk to taking this patch (and alternatives if risky): low
Wayne, Rob, this is a ESR only issue and has no check-ins to c-c.
Updated•4 years ago
|
Comment 8•4 years ago
|
||
Comment on attachment 9193569 [details] [diff] [review]
1676911-hc-qfb-button.patch
[Triage Comment]
Approved for esr78
Comment 9•4 years ago
|
||
bugherder |
Thunderbird 78.7.0:
https://hg.mozilla.org/releases/comm-esr78/rev/9699fb482b40
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Looks okay to me testing the 78.7.0 release candidate on Windows 10.
Updated•4 years ago
|
Description
•