Closed Bug 1676911 Opened 4 years ago Closed 4 years ago

Quickfilter bar buttons disappear when hovered over (with Windows 10 High Contrast Theme Black and TB default theme)

Categories

(Thunderbird :: Theme, defect)

defect

Tracking

(thunderbird_esr78 verified)

VERIFIED FIXED
Thunderbird 78.0
Tracking Status
thunderbird_esr78 --- verified

People

(Reporter: jhudson, Assigned: Paenglab)

Details

(Whiteboard: ESR only issue)

Attachments

(2 files, 1 obsolete file)

Attached image attachwhere.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

Hovered over filter by has attached button

Actual results:

the button disappeared

Expected results:

the button should have been highlighted

you are using the dark theme?

Component: Untriaged → Theme
Flags: needinfo?(jhudson)

Theme is still default. OS colors are High Contrast Black.

Flags: needinfo?(jhudson)
Summary: some buttons disappear when hovered over → some buttons disappear when hovered over (when OS colors are High Contrast Black)
Attached patch 1676911-hc-qfb-button.patch (obsolete) — Splinter Review

Alessandro, I know you have no Windows but this is a one-liner. It adds only the QFB bar to the High Contrast button variables.

This is a ESR only bug. On Daily it works after all my cleanup works.

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9193465 - Flags: review?(alessandro)

Better to ping Thomas or John for this Windows specific review.
From a pure CSS point of view it looks good to me.

John, please can you review this patch?

Attachment #9193465 - Attachment is obsolete: true
Attachment #9193465 - Flags: review?(alessandro)
Attachment #9193569 - Flags: review?(john)
Severity: -- → S3
Summary: some buttons disappear when hovered over (when OS colors are High Contrast Black) → With Windows 10 High Contrast Theme Black and TB default theme, Quickfilter bar buttons disappear when hovered over
Summary: With Windows 10 High Contrast Theme Black and TB default theme, Quickfilter bar buttons disappear when hovered over → Quickfilter bar buttons disappear when hovered over (with Windows 10 High Contrast Theme Black and TB default theme)
Comment on attachment 9193569 [details] [diff] [review] 1676911-hc-qfb-button.patch Review of attachment 9193569 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this fixes it. Thanks Richard! Should be uplifted to TB78 asap.
Attachment #9193569 - Flags: review?(john) → review+
Whiteboard: ESR only issue

Comment on attachment 9193569 [details] [diff] [review]
1676911-hc-qfb-button.patch

[Approval Request Comment]
User impact if declined: on Win 10 high contrast unreadable QFB buttons
Testing completed (on c-c, etc.): ESR only issue
Risk to taking this patch (and alternatives if risky): low

Wayne, Rob, this is a ESR only issue and has no check-ins to c-c.

Flags: needinfo?(vseerror)
Flags: needinfo?(rob)
Attachment #9193569 - Flags: approval-comm-esr78?
Flags: needinfo?(rob)

Comment on attachment 9193569 [details] [diff] [review]
1676911-hc-qfb-button.patch

[Triage Comment]
Approved for esr78

Flags: needinfo?(vseerror)
Attachment #9193569 - Flags: approval-comm-esr78? → approval-comm-esr78+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Looks okay to me testing the 78.7.0 release candidate on Windows 10.

Status: RESOLVED → VERIFIED
Target Milestone: --- → Thunderbird 78.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: