Closed Bug 1676988 Opened 10 months ago Closed 10 months ago

Use GetFrame instead of Seek in AnimationState::UpdateStateInternal

Categories

(Core :: ImageLib, defect)

defect

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

No description provided.

In https://hg.mozilla.org/integration/autoland/rev/471ad96ddc3e we changed this from calling |Surface().IsFullyDecoded()| to calling Seek because IsFullyDecoded always returns false for large enough animations because we don't keep around all of their frames.

However RequestRefresh/AdvanceFrame call GetFrame. Seek is intended to be used for display purposes, GetFrame is intended to be used for advancing the frame purposes. And Seek and GetFrame can actually returns different results if it is the first frame that we are asking for.

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c6e37699c60
Use GetFrame instead of Seek in AnimationState::UpdateStateInternal. r=aosmond
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.