Closed Bug 1676988 Opened 3 years ago Closed 3 years ago

Use GetFrame instead of Seek in AnimationState::UpdateStateInternal

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

Bug 1676988. Use GetFrame instead of Seek in AnimationState::UpdateStateInternal. r?aosmond
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

In https://hg.mozilla.org/integration/autoland/rev/471ad96ddc3e we changed this from calling |Surface().IsFullyDecoded()| to calling Seek because IsFullyDecoded always returns false for large enough animations because we don't keep around all of their frames.

However RequestRefresh/AdvanceFrame call GetFrame. Seek is intended to be used for display purposes, GetFrame is intended to be used for advancing the frame purposes. And Seek and GetFrame can actually returns different results if it is the first frame that we are asking for.

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c6e37699c60
Use GetFrame instead of Seek in AnimationState::UpdateStateInternal. r=aosmond

https://hg.mozilla.org/mozilla-central/rev/0c6e37699c60

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.