1677000 - Clean up IOutils redux

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task, P3)

Description

[Barret Rennie [:barret] (they/them)]

While working on bug 1676942 I ran into some things that should be cleaned up that and that work didn't make sense to do in that bug.

Comment 1

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1677000 - Remove IsAbsolutePath() from IOUtils.h r?gijs,emalysz

The implementation was removed in bug 1676942.

Comment 2

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1677000 - Pass Promise* to RejectJSPromise instead of RefPtr<Promise>& r?gijs

Depends on D98997

Comment 3

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1677000 - Refactor ResolveJSPromise out of RunOnBackgroundThread r?gijs

Depends on D98998

Comment 4

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1677000 - Add a type alias for MozPromise<T, IOError, true> r?gijs,emalysz

To use this type alias, IOUtils::InvokeToIOPromise had to become either a
member fn or a friend.

Depends on D98999

Comment 5

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1677000 - Rename IOUtils.writeAtomic{,UTF8} to IOUtils.write{,UTF8} r?emalysz,gijs

Depends on D99000

Comment 6

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1677000 - Remove unused IOUtils::WriteSync(PRFileDesc* ...) declaration r?emalysz,gijs

The implementation was removed in a previous change (bug 1665172) but the
declaration stuck around.

Depends on D99001

Comment 7

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1677000 - Address unpublished clang-tidy lints r?gijs,emalysz

There are two new lints introduced since IOUtils was written that we're hitting
now:

• IOUtils::InternalFileInfo's constructor does not initialize mType, mSize,
  mLastModified, and mPermissions; and
• We should be using a nested namespace statement.

We haven't hit them since these lines haven't been touched, but I noticed them
on the code review frontend.

Depends on D99155

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6592577cf0fa
Remove IsAbsolutePath() from IOUtils.h r=Gijs
https://hg.mozilla.org/integration/autoland/rev/8e6081b0c07d
Pass Promise* to RejectJSPromise instead of RefPtr<Promise>& r=Gijs
https://hg.mozilla.org/integration/autoland/rev/a5d7845d3c0c
Refactor ResolveJSPromise out of RunOnBackgroundThread r=Gijs
https://hg.mozilla.org/integration/autoland/rev/b2fa1a061b15
Add a type alias for MozPromise<T, IOError, true> r=Gijs
https://hg.mozilla.org/integration/autoland/rev/9dba15fdfe1f
Rename IOUtils.writeAtomic{,UTF8} to IOUtils.write{,UTF8} r=Gijs
https://hg.mozilla.org/integration/autoland/rev/737f380c2cf2
Remove unused IOUtils::WriteSync(PRFileDesc* ...) declaration r=Gijs
https://hg.mozilla.org/integration/autoland/rev/3521334cfc38
Address unpublished clang-tidy lints r=Gijs

Comment 9

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=3521334cfc38561e81522629d74b09ed6f4c1405&failure_classification_id=2

Logs:
https://treeherder.mozilla.org/logviewer?job_id=324007578&repo=autoland&lineNumber=2580
https://treeherder.mozilla.org/logviewer?job_id=324007537&repo=autoland&lineNumber=3372

Backout: https://hg.mozilla.org/integration/autoland/rev/36baeb20dfe6d2ed1a09a96e43b45daf1b730e82

Comment 10

[Barret Rennie [:barret] (they/them)]

Sorry about that. Find+replace gone wrong.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03dee0cdd71a
Remove IsAbsolutePath() from IOUtils.h r=Gijs
https://hg.mozilla.org/integration/autoland/rev/3b0a152f733f
Pass Promise* to RejectJSPromise instead of RefPtr<Promise>& r=Gijs
https://hg.mozilla.org/integration/autoland/rev/7331b21c377f
Refactor ResolveJSPromise out of RunOnBackgroundThread r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c4a169b3889c
Add a type alias for MozPromise<T, IOError, true> r=Gijs
https://hg.mozilla.org/integration/autoland/rev/9eb31bf4bcb4
Rename IOUtils.writeAtomic{,UTF8} to IOUtils.write{,UTF8} r=Gijs
https://hg.mozilla.org/integration/autoland/rev/d61d3d7f909c
Remove unused IOUtils::WriteSync(PRFileDesc* ...) declaration r=Gijs
https://hg.mozilla.org/integration/autoland/rev/6cc33208cf32
Address unpublished clang-tidy lints r=Gijs

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/03dee0cdd71a
https://hg.mozilla.org/mozilla-central/rev/3b0a152f733f
https://hg.mozilla.org/mozilla-central/rev/7331b21c377f
https://hg.mozilla.org/mozilla-central/rev/c4a169b3889c
https://hg.mozilla.org/mozilla-central/rev/9eb31bf4bcb4
https://hg.mozilla.org/mozilla-central/rev/d61d3d7f909c
https://hg.mozilla.org/mozilla-central/rev/6cc33208cf32