Closed Bug 1677000 Opened 1 year ago Closed 1 year ago

Clean up IOutils redux

Categories

(Toolkit :: OS.File, task, P3)

task

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: barret, Assigned: barret)

References

Details

Attachments

(7 files)

While working on bug 1676942 I ran into some things that should be cleaned up that and that work didn't make sense to do in that bug.

To use this type alias, IOUtils::InvokeToIOPromise had to become either a
member fn or a friend.

Depends on D98999

The implementation was removed in a previous change (bug 1665172) but the
declaration stuck around.

Depends on D99001

There are two new lints introduced since IOUtils was written that we're hitting
now:

  • IOUtils::InternalFileInfo's constructor does not initialize mType, mSize,
    mLastModified, and mPermissions; and
  • We should be using a nested namespace statement.

We haven't hit them since these lines haven't been touched, but I noticed them
on the code review frontend.

Depends on D99155

Attachment #9192086 - Attachment description: Bug 1677000 - Address unpublished clang-tidy lintes r?gijs,emalysz → Bug 1677000 - Address unpublished clang-tidy lints r?gijs,emalysz
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6592577cf0fa
Remove IsAbsolutePath() from IOUtils.h r=Gijs
https://hg.mozilla.org/integration/autoland/rev/8e6081b0c07d
Pass Promise* to RejectJSPromise instead of RefPtr<Promise>& r=Gijs
https://hg.mozilla.org/integration/autoland/rev/a5d7845d3c0c
Refactor ResolveJSPromise out of RunOnBackgroundThread r=Gijs
https://hg.mozilla.org/integration/autoland/rev/b2fa1a061b15
Add a type alias for MozPromise<T, IOError, true> r=Gijs
https://hg.mozilla.org/integration/autoland/rev/9dba15fdfe1f
Rename IOUtils.writeAtomic{,UTF8} to IOUtils.write{,UTF8} r=Gijs
https://hg.mozilla.org/integration/autoland/rev/737f380c2cf2
Remove unused IOUtils::WriteSync(PRFileDesc* ...) declaration r=Gijs
https://hg.mozilla.org/integration/autoland/rev/3521334cfc38
Address unpublished clang-tidy lints r=Gijs

Sorry about that. Find+replace gone wrong.

Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03dee0cdd71a
Remove IsAbsolutePath() from IOUtils.h r=Gijs
https://hg.mozilla.org/integration/autoland/rev/3b0a152f733f
Pass Promise* to RejectJSPromise instead of RefPtr<Promise>& r=Gijs
https://hg.mozilla.org/integration/autoland/rev/7331b21c377f
Refactor ResolveJSPromise out of RunOnBackgroundThread r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c4a169b3889c
Add a type alias for MozPromise<T, IOError, true> r=Gijs
https://hg.mozilla.org/integration/autoland/rev/9eb31bf4bcb4
Rename IOUtils.writeAtomic{,UTF8} to IOUtils.write{,UTF8} r=Gijs
https://hg.mozilla.org/integration/autoland/rev/d61d3d7f909c
Remove unused IOUtils::WriteSync(PRFileDesc* ...) declaration r=Gijs
https://hg.mozilla.org/integration/autoland/rev/6cc33208cf32
Address unpublished clang-tidy lints r=Gijs
You need to log in before you can comment on or make changes to this bug.