Closed
Bug 1677022
Opened 4 years ago
Closed 4 years ago
Allow to run toolchain tasks on mac workers
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(firefox84 fixed, firefox85 fixed)
RESOLVED
FIXED
85 Branch
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
By using a string instead of list for the command, we leave it to
the run-task transform to wrap with bash, which we don't need to do
ourselves anymore.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/3011377b3db0
Allow to run toolchain tasks on mac workers. r=taskgraph-reviewers,aki
Comment 3•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox85:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9187583 [details]
Bug 1677022 - Allow to run toolchain tasks on mac workers.
Beta/Release Uplift Approval Request
- User impact if declined: Indirect dependency of bug 1678485
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Decision task change that is a no-op for existing tasks and allows to setup tasks in bug 1678154
- String changes made/needed:
Attachment #9187583 -
Flags: approval-mozilla-beta?
Comment 5•4 years ago
|
||
Comment on attachment 9187583 [details]
Bug 1677022 - Allow to run toolchain tasks on mac workers.
Approved for 84.0b4.
Attachment #9187583 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•4 years ago
|
||
bugherder uplift |
status-firefox84:
--- → fixed
Assignee | ||
Comment 7•4 years ago
|
||
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/f873de376898
Followup to unbust toolchain tasks with no arguments.
Assignee | ||
Comment 9•4 years ago
|
||
Comment on attachment 9189784 [details]
Bug 1677022 - Followup to unbust toolchain tasks with no arguments.
Beta/Release Uplift Approval Request
- User impact if declined: Follow up for the patch that already landed. While the toolchain tasks are not expected to run on beta/release, and thus shouldn't hit the problem, it's better to be safe than sorry.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): NPOTB
- String changes made/needed:
Attachment #9189784 -
Flags: approval-mozilla-beta?
Comment 10•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Updated•4 years ago
|
Attachment #9189784 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 11•4 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•