1677076 - [Enhancement] Consider removing the default search engine from the entries in “Add Search Engine” of the Top Sites section

Status: NEW

(Firefox :: Top Sites, enhancement, P3)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: default search engine displayed.gif

[Notes]:

• Since Top Sites (including Sponsored) are no longer displayed in the case they have been set as a default search engine, it would make sense for consistency of the behavior across this section to also have the search engine not be displayed in the “Add Search Engine” modal.
• The Amazon Top Site is initially displayed, but after setting Amazon as the default search engine, the Amazon tile is no longer displayed.
• We would also need to make sure that the option is displayed again after that search engine is no longer default.

[Affected versions]:

• Firefox Beta 83 (Build ID: 20201112153044)
• Firefox Nightly 84.0a1 (Build ID: 20201108212832)

[Affected Platforms]:

• Windows
• macOS
• Linux

[Prerequisites]:

• Have Firefox Beta 83 installed and open.
• Be enrolled in a treatment branch of the “TopSites Launch Phase 3” experiment:
  • Use the Stage environment.
  • browser.partnerlink.useAttributionURL set to true
  • browser.topsites.experiment.ebay-2020-1 set to true
  • browser.search.experiment set to amazondotcom-adm
  • browser.topsites.useRemoteSetting set to true

[Steps to reproduce]:

1. Open a new tab.
2. Change the default engine to Amazon from “about:preferences#search”.
3. Click “Add Search Engine” from the Top SItes section Context Menu.
4. Observe the entries displayed.

[Proposed result]:

• The Amazon (or any other default search engine) is NOT displayed as a tile in the “Add Search Engine” modal.

[Current result]:

• The Amazon (or any other default search engine) is displayed as a tile in the “Add Search Engine” modal.

[Additional Notes]:

• The current behavior is the same when using non-remote settings Top Sites.
• This is related to Bug 1674270 and Bug 1663630.
• I am attaching a recording of the current behavior.

Comment 1

[Dão Gottwald [:dao]]

(In reply to Maria Heres, :mheres, Ecosystem QA from comment #0)

[Additional Notes]:

• The current behavior is the same when using non-remote settings Top Sites.

So... I'll remove this from the remote settings meta bugs.

Comment 2

[Maria Heres, inactive, contact Ecosystem QA]

I apologize for adding the feature meta too. I will be re-adding Bug 1677064 as that is just a tracking bug for QA to know in which phase the enhancement was logged.