Add Telemetry for tracking multiple PiP support usage
Categories
(Core :: Audio/Video: Playback, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: whjones526, Assigned: whjones526, NeedInfo)
References
Details
Attachments
(2 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
2.50 KB,
text/plain
|
chutten
:
data-review+
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0
|
||
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
I think what we might want to do is add a probe that counts how many users actually enter the state where they're using more than one player window.
What we could do is have the PictureInPictureParent actors, upon instantiation, increment a counter in the PictureInPicture object, and upon destruction (via didDestroy), decrement that counter. Then, in an else branch here: https://searchfox.org/mozilla-central/rev/44e6dfd7e02edd95e5fd4d4c25c8b946131f92cd/toolkit/components/pictureinpicture/PictureInPicture.jsm#314-318
we can record the probe if that count > 0.
Hunter, I suggest adding in the counter that increments and decrements. I'll go into detail on what kind of probe to add (and how to add it) in a follow-up comment.
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
||
Comment 3•3 years ago
|
||
ni?ing myself to get data-review on this new probe.
|
||
Comment 4•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:whjones526, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
||
Comment 5•3 years ago
|
||
|
|
||
Comment 6•3 years ago
|
||
Hey Hunter, if you have a second, would you mind updating this probe to expire in version 91 instead of 90? The holiday delayed the landing of this patch, and so we should move the expiry to get the full 5-6 months of data and analysis.
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9196393 [details]
Data review request.md
DATA COLLECTION REVIEW RESPONSE:
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes.
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.
If the request is for permanent data collection, is there someone who will monitor the data over time?
No. This collection will expire in six months.
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 2, Interaction.
Is the data collection request for default-on or default-off?
Default on for all channels.
Does the instrumentation include the addition of any new identifiers?
No.
Is the data collection covered by the existing Firefox privacy notice?
Yes.
Does there need to be a check-in in the future to determine whether to renew the data?
Yes. :mconley is responsible for renewing or removing the collection before it expires in six months.
Result: datareview+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/42e16aa681b2 Add Telemetry for tracking multiple PiP support usage r=Gijs
|
||
Comment 9•3 years ago
|
||
Backed out changeset 42e16aa681b2 (Bug 1677107) for causing failures in browser_multiPip.js
Failure log: https://treeherder.mozilla.org/logviewer?job_id=326469520&repo=autoland&lineNumber=3306
Backout: https://hg.mozilla.org/integration/autoland/rev/9dede9aa3281f22603f4a9df42b9ecd94008060a
|
||
Comment 10•3 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3636a378a600 Add Telemetry for tracking multiple PiP support usage r=Gijs
|
||
Comment 11•3 years ago
|
||
| bugherder | ||
Description
•