Closed Bug 1677107 Opened 6 months ago Closed 4 months ago

Add Telemetry for tracking multiple PiP support usage

Categories

(Core :: Audio/Video: Playback, enhancement)

Firefox 84
enhancement

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: whjones526, Assigned: whjones526, NeedInfo)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Assignee: nobody → whjones526
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

I think what we might want to do is add a probe that counts how many users actually enter the state where they're using more than one player window.

What we could do is have the PictureInPictureParent actors, upon instantiation, increment a counter in the PictureInPicture object, and upon destruction (via didDestroy), decrement that counter. Then, in an else branch here: https://searchfox.org/mozilla-central/rev/44e6dfd7e02edd95e5fd4d4c25c8b946131f92cd/toolkit/components/pictureinpicture/PictureInPicture.jsm#314-318

we can record the probe if that count > 0.

Hunter, I suggest adding in the counter that increments and decrements. I'll go into detail on what kind of probe to add (and how to add it) in a follow-up comment.

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core

ni?ing myself to get data-review on this new probe.

Flags: needinfo?(mconley)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:whjones526, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(whjones526)
Attached file Data review request.md
Flags: needinfo?(mconley)
Attachment #9196393 - Flags: data-review?(chutten)

Hey Hunter, if you have a second, would you mind updating this probe to expire in version 91 instead of 90? The holiday delayed the landing of this patch, and so we should move the expiry to get the full 5-6 months of data and analysis.

Comment on attachment 9196393 [details]
Data review request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in six months.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :mconley is responsible for renewing or removing the collection before it expires in six months.


Result: datareview+

Attachment #9196393 - Flags: data-review?(chutten) → data-review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/42e16aa681b2
Add Telemetry for tracking multiple PiP support usage r=Gijs
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3636a378a600
Add Telemetry for tracking multiple PiP support usage r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
See Also: → 1706843
You need to log in before you can comment on or make changes to this bug.