1677135 - Langpacks are being shutdown() with reason = undefined when quitting Firefox

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[Dale Harvey (:daleharvey)]

I have a local build in which I install the en-GB langpack

Using this local build every time I shutdown Firefox using Nightly > Quit Nightly menu bar I can see the "intl:app-locales-changed" event being fired, it would seem this is because the langpack is being shutdown, I put a log statement in

https://searchfox.org/mozilla-central/source/toolkit/components/extensions/Extension.jsm#2876

and can see that shutdown is being called with reason = undefined

Curiously (possibly but not for sure related is that in the event handler we check for Services.startup.shuttingDown which is still reporting false for me at this point

https://searchfox.org/mozilla-central/source/toolkit/components/search/SearchService.jsm#2574

Comment 1

[Shane Caraveo (:mixedpuppy)]

It's probably this:

https://searchfox.org/mozilla-central/rev/44e6dfd7e02edd95e5fd4d4c25c8b946131f92cd/toolkit/components/extensions/Extension.jsm#1858

Comment 2

[Shane Caraveo (:mixedpuppy)]

I'm part way on this though a little refactoring is going to be necessary.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Bug 1305705 added the APP_SHUTDOWN check, however reason was never passed to this call, no test in the patch and QA verification passed on the bug, and it was uplifted.

:(

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1677135 fix APP_SHUTDOWN for langpacks

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e3c709a56b91f1911c48d8abb81cc9786e6ee0d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3947f6228f3
fix APP_SHUTDOWN for langpacks r=rpl,zbraniecki

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b3947f6228f3