Closed Bug 1677136 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26526 - [LayoutNG] Carry over incoming inline break token when no new lines.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox85 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26526 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26526
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

[LayoutNG] Carry over incoming inline break token when no new lines.

If we want to break before the first line in a fragment, we need to
check if there's an incoming inline break token, and add that one to the
builder, rather than assuming that we should always resume at the
beginning of the inline formatting context.

The new test would either freeze or trigger a DCHECK failure without
this fix.

Bug: 1122901
Change-Id: Ib698d477aef18d11dbe1436eaf12d5d52bdc023d
Reviewed-on: https://chromium-review.googlesource.com/2537834
WPT-Export-Revision: 1c9239240351925d459c2a3316a207b0a3b0a38a

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/line-pushed-by-float-001.html: FAIL

New Tests That Don't Pass

/css/css-break/line-pushed-by-float-001.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1b99347a7fe
[wpt PR 26526] - [LayoutNG] Carry over incoming inline break token when no new lines., a=testonly
https://hg.mozilla.org/integration/autoland/rev/c7c669ffec53
[wpt PR 26526] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f1b99347a7fe
https://hg.mozilla.org/mozilla-central/rev/c7c669ffec53

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.