1677168 - nsFilePicker cleanup

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Description

[(No longer employed by Mozilla) Aaron Klotz]

There is a bunch of stuff in nsFilePicker that is either crufty, redundant, or didn't work right. I'd like to land this work as a prereq to moving file pickers out of process.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e87ddfca530c5e6b003a628ba6982ae813ea7c1a

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1677168: nsFilePicker cleanup; r=jmathies,cmartin,mhowell

• We replace mLastUsedUnicodeDirectory and its manual memory managemnt with a
  UniquePtr named sLastUsedUnicodeDirectory
• We remove AutoRestoreWorkingPath, as it never was actually necessary and
  was left in, "just in case."
• We remove the timeout stuff, as that never actually worked, at least with
  the current implementation of the file picker; perhaps it worked with the
  legacy file picker APIs, but it doesn't work with the Vista+, COM-based stuff.
• We also get rid of IFileDialogEvents, as all of that stuff was needed for
  timeouts. It also adds additional complexity that impairs our ability to
  implement out-of-process file pickers in a future bug.
• We replace do_CreateInstance("@mozilla.org/file/local;1") with
  NS_NewLocalFile.
• We add HRESULT error handling to all of the method invocations on COM
  interfaces.
• We replace CLSCTX_INPROC with CLSCTX_INPROC_SERVER in CoCreateInstance
  calls.
• We remove CoInitialize and CoUninitialize calls. Those have been
  unnecessary ever since we added mscom::ProcessRuntime instantiation during
  startup.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d09267457f7
nsFilePicker cleanup; r=mhowell

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2d09267457f7