1677183 - Implement Queue.copyImageBitmapToTexture in WebGPU

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, enhancement)

Description

[Dzmitry Malyshau [:kvark]]

See https://gpuweb.github.io/gpuweb/#dom-gpuqueue-copyimagebitmaptotexture

This is required to run the textured-cube WebGPU example.

Comment 1

[Dzmitry Malyshau [:kvark]]

Related to our ability to flip Y

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1677183 - Implement WebGPU's Queue.copyExternalImageToTexture. r=jgilbert

Comment 3

[Kelsey Gilbert [:jgilbert]]

Here's what I ended up thinking about CORS:

Only DOM element objects have CORS.
Both DOM element objects and non-DOM objects have "origin-clean" flags.
In Gecko, we implement origin-clean via isWriteOnly, where origin-clean IFF !isWriteOnly.

See
https://html.spec.whatwg.org/multipage/canvas.html#the-image-argument-is-not-origin-clean for how CORS becomes origin-clean = false.

See https://html.spec.whatwg.org/multipage/canvas.html#security-with-canvas-elements for how this propagates.

In particular:

All bitmaps start with their origin-clean set to true. The flag is set to false when cross-origin images are used.

The value of the origin-clean flag is propagated from a source canvas element's bitmap to a new ImageBitmap object by createImageBitmap(). Conversely, a destination canvas element's bitmap will have its origin-clean flags set to false by drawImage if the source image is an ImageBitmap object whose bitmap has its origin-clean flag set to false.

I think we might have some of our CORS checks wrong, but I want to think more about it. But this is unblocked and good to land.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e76508f9136
Implement WebGPU's Queue.copyExternalImageToTexture. r=jgilbert,jimb,emilio

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on test_queue_copyExternalImageToTexture.html

Backout link

Push with failures

Failure log 1 // Failure log 2

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/746fbd28a600
Implement WebGPU's Queue.copyExternalImageToTexture. r=jgilbert,jimb,emilio

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/746fbd28a600