Extend pre-xul skeleton UI to set correct margins based on the menubar
Categories
(Firefox :: General, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: emmamalysz, Assigned: emmamalysz)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We should set correct client margins based on whether the menubar is present (potentially adding placeholder rect(s) for the dropdowns like file,edit, view, etc), or we should just turn off the skeleton UI off if it is present.
|
||
Comment 1•4 years ago
|
||
I believe this is a dupe of bug 1673092, unless I'm missing something?
|
Assignee | |
Comment 2•4 years ago
|
||
I can toggle the value of browser.tabs.drawInTitlebar and still always show the menubar, so this looks to be independent of the pref. If the pref is false and the menubar is showing, it's an even larger margin.
I don't actually think the menubar is controlled by a pref, so we may have to check if the CustomizableUI.AREA_MENUBAR was registered? Or for the presence of menu-bar items
|
|
Assignee | |
Comment 3•4 years ago
|
||
The menubar is permanently shown if autohide is false. If that is the case, we
insert space above the tab and ensure the tab does not have a left margin.
|
||
Updated•4 years ago
|
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b08960fa0ebb update margins in skeleton UI if menubar is shown r=dthayer
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Description
•