1677185 - Extend pre-xul skeleton UI to set correct margins based on the menubar

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Emma Malysz]

We should set correct client margins based on whether the menubar is present (potentially adding placeholder rect(s) for the dropdowns like file,edit, view, etc), or we should just turn off the skeleton UI off if it is present.

Comment 1

[Alex Thayer [:alexical] (she/her)]

I believe this is a dupe of bug 1673092, unless I'm missing something?

Comment 2

[Emma Malysz]

I can toggle the value of browser.tabs.drawInTitlebar and still always show the menubar, so this looks to be independent of the pref. If the pref is false and the menubar is showing, it's an even larger margin.

I don't actually think the menubar is controlled by a pref, so we may have to check if the CustomizableUI.AREA_MENUBAR was registered? Or for the presence of menu-bar items

Comment 3

[Emma Malysz]

Attachment: Bug 1677185, update margins in skeleton UI if menubar is shown

The menubar is permanently shown if autohide is false. If that is the case, we
insert space above the tab and ensure the tab does not have a left margin.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b08960fa0ebb
update margins in skeleton UI if menubar is shown r=dthayer

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b08960fa0ebb