Closed Bug 1677242 Opened 4 years ago Closed 2 years ago

[wpt-sync] Sync PR 26534 - Safer style reset for abspos dialog layout tests

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26534 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26534
Details from upstream follow.

b'Darryl Pogue <darryl@dpogue.ca>' wrote:

Safer style reset for abspos dialog layout tests

As written, if these tests fail, then the line to reset back to the initial state never runs, leading to the style changes bleeding between tests. This happens to not cause any issues currently, but might pose a risk if more tests are added.

There's already a cleanup step that is guaranteed to run after every test, so it's better to move the style resets to run as part of that.

Also, setting height = 'fit-content' is a silent no-op in browsers that don't support fit-content (or support it with a prefix, like -moz-fit-content), so the best way to reset back to default styles is to assign null.

/cc @bfgeek

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Try push failed: decision task XxrEMdtnTVKw7cgB-p44iQ returned error
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33ea3416a5ff
[wpt PR 26534] - Safer style reset for abspos dialog layout tests, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/33ea3416a5ff

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.