Closed Bug 1677268 Opened 8 months ago Closed 8 months ago

[wpt-sync] Sync PR 26536 - Do not parse @counter-style rules with invalid names

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26536 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26536
Details from upstream follow.

b'Xiaocheng Hu <xiaochengh@chromium.org>' wrote:

Do not parse @counter-style rules with invalid names

The spec requires a @counter-style rule to be invalid if its name is
among the disallowed values. This patch implements it.

Bug: 687225
Change-Id: Ib4c06453c30301cbc64e18950c8686fe63e08220
Reviewed-on: https://chromium-review.googlesource.com/2533855
WPT-Export-Revision: 37f39fdf496c0c6db3e3bb47c0f3dd219e6d97ff

PR 26536 applied with additional changes from upstream: 8bfc648029ce9bdd20eecc3451195e6fe4c10a2f
Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 15 subtests

Status Summary

Firefox

OK : 10
PASS: 93
FAIL: 8

Chrome

OK : 10
PASS: 50
FAIL: 51

Safari

OK : 10
PASS: 50
FAIL: 51

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-counter-styles/counter-style-prefix-suffix-syntax.html
@counter-style 'prefix: url("https://example.com/foo.png")' is valid: FAIL (Chrome: FAIL, Safari: FAIL)
@counter-style 'suffix: url("https://example.com/foo.png")' is valid: FAIL (Chrome: FAIL, Safari: FAIL)
@counter-style 'prefix: url(https://example.com/foo.png)' is valid: FAIL (Chrome: FAIL, Safari: FAIL)
@counter-style 'suffix: url(https://example.com/foo.png)' is valid: FAIL (Chrome: FAIL, Safari: FAIL)
@counter-style 'prefix: linear-gradient(yellow, blue)' is valid: FAIL (Chrome: FAIL, Safari: FAIL)
@counter-style 'suffix: linear-gradient(yellow, blue)' is valid: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-counter-styles/counter-style-speak-as-syntax.html
@counter-style 'speak-as: spell-out' is valid: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-counter-styles/counter-style-symbols-syntax.html
@counter-style 'symbols: ident "X" url("foo.jpg")' is valid: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/974b37eb0074
[wpt PR 26536] - Do not parse @counter-style rules with invalid names, a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.