Closed Bug 1677302 Opened 2 months ago Closed 2 months ago

Remove KeyboardScrollAnimation

Categories

(Core :: Panning and Zooming, task, P3)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: kats, Assigned: sunitacool41, Mentored)

References

Details

(Whiteboard: [lang=c++])

Attachments

(1 file)

Bug 1666340 replaced the usage of KeyboardScrollAnimation with SmoothScrollAnimation. KeyboardScrollAnimation should no longer be used anywhere and can be removed.

Hello,
I would like to work on this.
Last time when I removed KeyboardScrollAnimation.cpp and KeyboardScrollAnimation.h there were errors during the build. And those were resolved only when I removed this line.
Are we allowed to edit .build files?
Or was it some fault at my local machine?

Yeah, you will need to remove the line in the moz.build file so that the build system doesn't try to build it. Thanks for taking this!

Assignee: nobody → sunitacool41
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Thank you again Sunita! Let me know if you need help picking another bug to work on!

Hello,
Thank you for guiding. :)
It will be great if you can help me with picking another bug. Thanks!

I filed bug 1677744 which is another relatively simple one you could pick up. I have another one in mind also that's a bit more involved, but I have to check a couple other things first before I can properly mentor that one. It should be ready to work on by the time you're done with bug 1677744, if you choose to work on it.

You need to log in before you can comment on or make changes to this bug.