1677401 - Make fully-packed subset of scope AbstractData for stencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

Currently stencil and VM share single definition of scope AbstractData.
there are some problems:

• GC pointer types shouldn't be part of stencil
  • FunctionScope::AbstractData::canonicalFunction
  • ModuleScope::AbstractData::module
  • WasmInstanceScope::AbstractData::instance
• some AbstractData aren't packed, and not compatible with direct XDR encoding/decoding or pinned data
• while instantiation, we copy header from stencil to VM data, but it copies padding too

Comment 1

[Tooru Fujisawa [:arai]]

Once we have fully-packed scope data, we can encode/decode the scope data at once by codeBytes

Comment 2

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8620aed38ec38029d6b3abb448a59d1a5c9cee2f

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1677401 - Part 1: Add scope SlotInfo struct for shared data between stencil and VM. r?nbp!

Depends on D99652

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1677401 - Part 2: Remove pointer from stencil scope data. r?nbp!

Split *Scope::Data into stencil and VM, with specialization for each.
Stencil variant doesn't contain pointer fields.

Depends on D99744

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1677401 - Part 3: Move alignas to JSAtom scope data. r?nbp!

Stencil's *Scope::Data doesn't contain pointer and doesn't have to be aligned
to pointer size.
This removed extra padding between scope data items in vector.

Depends on D99745

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1677401 - Part 4: Make ParserFunctionScopeData packed. r?nbp!

Depends on D99746

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1677401 - Part 5: Encode/decode the entire scope data at once. r?nbp!

Depends on D99747

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1677401 - Part 6: Directly use ParserData type. r?nbp!

Depends on D99748

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0940ad526195
Part 1: Add scope SlotInfo struct for shared data between stencil and VM. r=nbp
https://hg.mozilla.org/integration/autoland/rev/bbbeb29c04c2
Part 2: Remove pointer from stencil scope data. r=nbp
https://hg.mozilla.org/integration/autoland/rev/c972b09c5e56
Part 3: Move alignas to JSAtom scope data. r=nbp
https://hg.mozilla.org/integration/autoland/rev/fb9fcbb1a089
Part 4: Make ParserFunctionScopeData packed. r=nbp
https://hg.mozilla.org/integration/autoland/rev/798cf3bb1173
Part 5: Encode/decode the entire scope data at once. r=nbp
https://hg.mozilla.org/integration/autoland/rev/22cc55f37833
Part 6: Directly use ParserData type. r=nbp

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0940ad526195
https://hg.mozilla.org/mozilla-central/rev/bbbeb29c04c2
https://hg.mozilla.org/mozilla-central/rev/c972b09c5e56
https://hg.mozilla.org/mozilla-central/rev/fb9fcbb1a089
https://hg.mozilla.org/mozilla-central/rev/798cf3bb1173
https://hg.mozilla.org/mozilla-central/rev/22cc55f37833