Closed Bug 1677415 Opened 5 years ago Closed 2 years ago

Report Site Button is ineffective on xichlo.owst.jp

Categories

(Web Compatibility :: Tooling & Investigations, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: karlcow, Unassigned)

References

()

Details

  1. Go to https://xichlo.owst.jp/menu
  2. Select Report Site Issue… in the ººº menu in the URL bar

Expected:
URL bar is filed in the new tab.

Actual:
no url is added to the new tab.

Can't reproduce; but given https://bugzilla.mozilla.org/show_bug.cgi?id=1677333#c12, a race-condition is not impossible.

We currently post the message containing the report payload at document_end, and it's quite possible that this runs before all the JS is executed.

We could have it run at document_idle, which would probably fix the issues here, but that feels like a not-ideal workaround given it takes even longer for the fields to get filled, and there already is a noticeable delay. I'm wondering if it would be better to dump the report information into a global object (window.PREFILLED_WEBCOMPAT_REPORT or whatever), and have the form's JS pick that up as soon as it can. Tom, as you built the reporter, WDYT?

Flags: needinfo?(wisniewskit)

Yes, I think you're right, Dennis. We would probably be best off both setting a window property and sending a message, to catch both possible outcomes in a race. We would need to alter webcompat.com to check for that new property, or that failing, wait for the current message.

Flags: needinfo?(wisniewskit)

We have now made the changes to webcompat.com and Report Site Issue which fixed this (in bug 1852340).

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.