Closed Bug 1677416 Opened 5 years ago Closed 5 years ago

Don't use <input type="number"> for MFA form on mobile

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Product:
bugzilla.mozilla.org
Component:
User Interface
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

References

(Regression)

Details

Problem is here: https://github.com/mozilla-bteam/bmo/blob/5dbd0ec17a27011b8a89a6778fa7826820dcc4e5/template/en/default/mfa/totp/verify.html.tmpl#L26-L28

Actually, BMO on mobile uses <input type="number"> to input verify code by MFA. This is incorrect to input it. type=number won't input "0" for head number.

Best practice for 2FA is type="tel" (https://web.dev/sign-in-form-best-practices/) or use inputmode. All modern mobile browsers (inc. Fenix) support inputmode attribute, so we should use inputmode instead of type=tel.

Regressed by: 1213033

Merged to master. Will be in the next deployment. Thanks!

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → m_kato
You need to log in before you can comment on or make changes to this bug.