Closed Bug 1677430 Opened 3 years ago Closed 3 years ago

mozlint/license: Handle the error when cannot open a file

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

% ./mach lint -l license /home/sylvestre/dev/mozilla/mozilla-central.hg/testing/web-platform/tests/css/CSS2/syntax/support/at-charset-001.css -n --fix
Traceback (most recent call last):
  File "/home/sylvestre/dev/mozilla/autoland/python/mozlint/mozlint/roller.py", line 64, in _run_worker
    res = func(paths, config, **lintargs) or []
  File "/home/sylvestre/dev/mozilla/autoland/python/mozlint/mozlint/types.py", line 57, in __call__
    return self._lint(paths, config, **lintargs)
  File "/home/sylvestre/dev/mozilla/autoland/python/mozlint/mozlint/types.py", line 148, in _lint
    return func(files, config, **lintargs)
  File "/home/sylvestre/dev/mozilla/autoland/tools/lint/license/__init__.py", line 183, in lint
    fix_me(f)
  File "/home/sylvestre/dev/mozilla/autoland/tools/lint/license/__init__.py", line 138, in fix_me
    add_header(filename, license)
  File "/home/sylvestre/dev/mozilla/autoland/tools/lint/license/__init__.py", line 63, in add_header
    lines = f.readlines()
  File "/usr/lib/python3.8/codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x95 in position 33: invalid start byte
A failure occurred in the license linter.
✖ 1 problem (0 errors, 0 warnings, 1 failure)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9afd191e4d79
mozlint/license: Handle the error when cannot open a file r=linter-reviewers,ahal DONTBUILD
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: