1677433 - private fields and private methods

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[holz1]

Attachment: 99191288-2d9ac100-276c-11eb-8759-31da1616ff95.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.193 Safari/537.36

Steps to reproduce:

Adding javascript.options.experimental.private_fields and javascript.options.experimental.private_methods is not working.

Actual results:

Still getting "Uncaught SyntaxError: private fields are not currently supported"

Expected results:

no error

Comment 1

[Andre Klapper]

Still getting "Uncaught SyntaxError: private fields are not currently supported"

How? Where? Please provide complete steps to reproduce.

Comment 2

[holz1]

Attachment: 03_objects_privateProperties_simple.zip

Comment 3

[holz1]

with this program: see attached file: https://bugzilla.mozilla.org/attachment.cgi?id=9187985

Comment 4

[Hani Yacoub, Desktop QA]

On MacOS 10.14 on the latest Firefox Nightly after I set the prefs as mentioned in the description the results are: https://imgur.com/a/t2iSDjM
O MacOS 10.14 on the latest Firefox Nightly without setting the prefs the results are: https://imgur.com/a/ML99Kbf

On Windows 10 x64 on the latest Firefox Nightly with or without the prefs the results are as on Mac without the prefs: https://imgur.com/a/ML99Kbf

Is this the problem that you are facing?
Thanks.

Comment 5

[holz1]

I still get this after setting the prefs: https://imgur.com/a/sQi0oye (Firefox 83, Windows 10).

Comment 6

[holz1]

Its working in Firefox Nightly (85.0a1) https://imgur.com/a/Yv934x5

Comment 7

[Tom S. (please needinfo tschuster)]

These prefs will only work on Nightly builds: https://searchfox.org/mozilla-central/rev/1d34bd022de0b55c81d9db6026f69bda1d4a86d2/js/xpconnect/src/XPCJSContext.cpp#1014

Comment 8

[Matthew Gaudet (he/him) [:mgaudet]]

As Tom says, these prefs are only active on Nightly, as the feature isn't quite ready to ship. We're waiting on improving the storage efficiency of private methods before we ship.

I'm going to mark this as RESOLVED/INVALID just because this is working as expected at the moment.

I'm hoping we can ship these soon too :)