1677464 - screen.orientation returns always "landscape-primary" on Microsoft Surface Books (Windows 10)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Christian Schneider]

Attachment: rotation.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.132 Safari/537.36

Steps to reproduce:

1. Open Firefox on a Microsoft Surface Book
2. Undock it from the keyboard so that tablet mode is enabled
3. Inside the inspector check what screen.orientation returns.
4. Rotate the surface book 90°
5. Inside the inspector check what screen.orientation returns.

Actual results:

No rotation change is reflected. Both calls return

ScreenOrientation { type: "portrait-primary", angle: 0, onchange: null }

Expected results:

The second call should return

ScreenOrientation { type: "landscape-primary", angle: 90, onchange: null }

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Sam Foster [:sfoster] (he/him)]

I'm trying to find the correct component for this. Its somewhere in DOM I guess?

Comment 3

[Christian Schneider]

The bug is about the implementation of this https://developer.mozilla.org/en-US/docs/Web/API/Screen/orientation interface (it occurs on a Surface Book (which is a combination of Desktop- and Tablet-Device). I'm not sure to which Firefox Component it belongs.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1677464 - Set screen orientation type and angle from OS API. r=gsvelto

Windows can get current screen orientation from OS API.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef65febc92a8
Set screen orientation type and angle from OS API. r=gsvelto

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ef65febc92a8